[Repo Assist] test: upgrade assert.NoError to require.NoError where result is used downstream

[github-actions]

🤖 This PR is from Repo Assist, an automated AI assistant for this repository.

Summary

In 4 test locations across internal/difc/ and internal/guard/, assert.NoError was used immediately before code that dereferences or type-asserts the returned result. When the error check fails, this pattern produces cascaded failures with confusing messages (e.g. "expected nil, got non-nil" on a type assertion) rather than pointing directly at the unexpected error.

This PR upgrades those 4 calls to require.NoError, which stops the test on the first failure and surfaces the actual error immediately.

Changes

File	Line	Before	After	Why
internal/difc/evaluator_test.go	772	assert.NoError	require.NoError	Followed by assert.Equal(t, tt.expected, mode) — mode is zero-value when err≠nil
internal/difc/resource_test.go	104	assert.NoError	require.NoError	Followed by assert.Equal(t, tt.data, result) — result is nil when err≠nil
internal/difc/resource_test.go	585	assert.NoError(err) (bound)	require.NoError(t, err)	Followed by type assertion result.([]interface{}) — nil result gives ok=false, obscuring the real error
internal/guard/wasm_test.go	1179	assert.NoError	require.NoError	Followed by assert.NotNil(t, result) and require.IsType(...) — nil result produces misleading failure

All require imports were already present in the affected files. No behaviour changes in production code; no new dependencies.

Test Status

⚠️ Infrastructure note: proxy.golang.org is blocked in the CI environment for this workflow run, preventing go test from building the test binaries (module cache missing zip files). This is a pre-existing infrastructure constraint — the changes are pure test-quality improvements with no logic impact. All 4 modified lines are syntactically verified with gofmt -l (no output = correctly formatted).

The changes are mechanical (same function call, different assert/require package prefix) and carry no execution risk.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by Repo Assist · 2.2K AIC · ⊞ 50.1K · ◷
_{Comment /repo-assist to run again}

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

[Copilot]

Pull request overview

This PR improves test failure clarity by replacing assert.NoError with require.NoError in cases where the test immediately uses the returned result, preventing cascaded follow-on failures and surfacing the real error at the point of failure.

Changes:

• Switched assert.NoError → require.NoError in ParseEnforcementMode tests before asserting on mode.
• Switched assert.NoError → require.NoError in ToResult()-related tests before dereferencing / type-asserting returned values.
• Switched assert.NoError → require.NoError in WASM path-label parsing tests before validating the returned labeled data type.

Show a summary per file

File	Description
internal/difc/evaluator_test.go	Uses require.NoError to stop the test before asserting on a possibly zero-value mode.
internal/difc/resource_test.go	Uses require.NoError to stop the test before comparing / type-asserting ToResult() output.
internal/guard/wasm_test.go	Uses require.NoError to stop the test before validating non-nil result and expected concrete type.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 0