[rust-guard] Deduplicate item_number extraction and add direct commit_integrity coverage

[Copilot]

helpers.rs repeated the same number extraction chain in nine integrity/logging paths, and commit_integrity had no direct unit coverage despite enforcing multiple security-critical integrity floors/elevations.

• Refactor: centralized issue/PR number extraction

  • Added a private helper in helpers.rs:
    • item_number(item: &Value) -> u64
  • Replaced all 9 duplicated number extraction sites (approval/promotion/demotion adjustments plus PR/issue blocked and collaborator-fallback logging paths) with item_number(item).

• Tests: direct coverage for commit_integrity decision paths

  • Added focused unit tests in helpers.rs for:
    • blocked author -> blocked integrity
    • default-branch commit -> merged floor
    • public non-default commit -> none baseline floor
    • private commit -> writer floor
    • private + default-branch commit -> merged floor
    • public owner-authored commit -> writer floor

• Example (deduped call site pattern)

#[inline]
fn item_number(item: &Value) -> u64 {
    item.get(field_names::NUMBER)
        .and_then(|v| v.as_u64())
        .unwrap_or(0)
}

// before: item.get(field_names::NUMBER).and_then(|v| v.as_u64()).unwrap_or(0)
let number = item_number(item);

[Copilot]

Pull request overview

This PR refactors the Rust guard labeling helpers to remove repeated JSON extraction logic for issue/PR numbers in integrity-related logging, and adds direct unit tests for commit_integrity to cover key decision paths that affect integrity labeling.

Changes:

• Added a private item_number(&Value) -> u64 helper to centralize number extraction for logging use cases.
• Replaced nine duplicated number extraction chains across integrity promotion/demotion and logging paths with item_number(item).
• Added unit tests that directly exercise commit_integrity outcomes across blocked-author, repo privacy, default-branch, and owner-authored scenarios.

Show a summary per file

File	Description
guards/github-guard/rust-guard/src/labels/helpers.rs	Deduplicates number extraction for logging and adds focused unit tests covering commit_integrity decision branches.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0