Deduplicate logger startup and shutdown wiring with shared registries

[Copilot]

The logger package had repeated startup/shutdown glue across five logger types: per-type global init/close wrappers were already backed by shared generic helpers, but gateway/proxy startup and CloseAllLoggers still relied on manually duplicated wiring. This change centralizes that orchestration without changing the public logger APIs or fallback behavior.

• What changed

  • Added shared registries for:
    • gateway logger initialization
    • proxy logger initialization
    • global logger shutdown
  • Replaced the hand-written sequences in InitGatewayLoggers, InitProxyLoggers, and CloseAllLoggers with registry iteration.

• Why this is smaller and safer

  • Keeps each logger’s explicit Init* / Close* entry points intact.
  • Moves the “which loggers participate, and in what order” concern into one place.
  • Reduces the chance of adding a new logger type but missing one of the package-level startup/cleanup paths.

• Package docs and coverage

  • Updated logger package documentation to note the centralized registry model.
  • Added focused tests that assert the expected registry membership and ordering for gateway, proxy, and global close paths.

• Shape of the refactor

  type loggerInitEntry struct {
      name string
      init func(logDir string) error
  }
  
  func InitGatewayLoggers(logDir string) {
      initLoggerSet(logDir, gatewayLoggerInitializers)
  }
  
  func CloseAllLoggers() error {
      return closeLoggerSet(globalLoggerClosers)
  }

[Copilot]

Pull request overview

This PR refactors internal/logger startup/shutdown orchestration by centralizing the “which loggers participate, and in what order” logic into shared registries, while preserving the existing per-logger Init*/Close* public APIs and non-fatal startup warning behavior.

Changes:

• Introduces shared gateway/proxy initializer registries and a global closer registry, plus small helpers to iterate them.
• Replaces hand-written sequences in InitGatewayLoggers, InitProxyLoggers, and CloseAllLoggers with registry iteration.
• Adds tests to assert registry membership and ordering; updates package documentation to describe the registry model.

Show a summary per file

File	Description
internal/logger/registry.go	Adds the shared initializer/closer registries and iteration helpers.
internal/logger/init.go	Switches gateway/proxy initialization to use the shared registries.
internal/logger/init_test.go	Adds tests asserting registry membership and ordering.
internal/logger/global_helpers.go	Switches CloseAllLoggers to use the shared closer registry.
internal/logger/common.go	Updates package documentation to describe the registry-based orchestration model.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 5/5 changed files
• Comments generated: 0