Skip to content

[WIP] Fix Go Logger Enhancement workflow failure#7485

Merged
lpcox merged 5 commits into
mainfrom
copilot/aw-fix-go-logger-enhancement
Jun 13, 2026
Merged

[WIP] Fix Go Logger Enhancement workflow failure#7485
lpcox merged 5 commits into
mainfrom
copilot/aw-fix-go-logger-enhancement

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor
  • Add debug logging to internal/tracing/fanout.go using the existing logTracing package-level logger
  • Validate changes with make agent-finished

GitHub Advanced Security started work on behalf of lpcox June 13, 2026 14:41 View session
GitHub Advanced Security finished work on behalf of lpcox June 13, 2026 14:43
GitHub Advanced Security started work on behalf of lpcox June 13, 2026 14:53 View session
GitHub Advanced Security finished work on behalf of lpcox June 13, 2026 14:54
Copilot AI requested a review from lpcox June 13, 2026 14:58
@lpcox lpcox marked this pull request as ready for review June 13, 2026 15:50
Copilot AI review requested due to automatic review settings June 13, 2026 15:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds additional debug logging around the tracing OTLP fanout span exporter to help diagnose/export/shutdown behavior and backend failures.

Changes:

  • Log when newFanoutExporter bypasses fanout (single exporter) vs creates a fanout exporter.
  • Log fanout export start, per-backend export errors, and a failure summary.
  • Log fanout shutdown start, per-backend shutdown errors, and completion status.
Show a summary per file
File Description
internal/tracing/fanout.go Adds debug logging around fanout exporter creation, span export, and shutdown flows.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

Comment thread internal/tracing/fanout.go Outdated
Comment thread internal/tracing/fanout.go Outdated
lpcox and others added 2 commits June 13, 2026 08:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
GitHub Advanced Security started work on behalf of lpcox June 13, 2026 15:58 View session
GitHub Advanced Security started work on behalf of lpcox June 13, 2026 15:58 View session
GitHub Advanced Security finished work on behalf of lpcox June 13, 2026 15:59
GitHub Advanced Security finished work on behalf of lpcox June 13, 2026 15:59
@lpcox

lpcox commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Adapt debug logging to the refactored forEachExporter helper
introduced in main (Refactor fanout exporter concurrent dispatch #7486).
The op string parameter to forEachExporter carries operation context into
per-backend error log messages, satisfying the reviewer request to
identify which exporter failed.

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Resolved in commit 61c8af0. The conflict arose because main refactored the concurrent dispatch logic into a new forEachExporter helper method. I adapted the debug logging to that new structure by adding an op string parameter to forEachExporter, which threads the operation name ("ExportSpans" / "Shutdown") into per-backend error log messages — addressing the reviewer's request to identify which exporter failed.

GitHub Advanced Security started work on behalf of lpcox June 13, 2026 16:07 View session
Copilot finished work on behalf of lpcox June 13, 2026 16:07
GitHub Advanced Security finished work on behalf of lpcox June 13, 2026 16:09
@lpcox lpcox merged commit a5b5c18 into main Jun 13, 2026
27 checks passed
@lpcox lpcox deleted the copilot/aw-fix-go-logger-enhancement branch June 13, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants