rust-guard: delegate parse_integrity to MinIntegrity::from_policy_str + add response_items tests

[Copilot]

parse_integrity in lib.rs duplicated a 4-arm match already implemented (case-insensitively, with whitespace trimming) in MinIntegrity::from_policy_str. labels/response_items.rs had zero test coverage despite being on the security-sensitive response-labeling path.

Changes

lib.rs — eliminate duplication in parse_integrity

• Replace 4-arm match with a single delegation to MinIntegrity::from_policy_str, gaining case-insensitivity and whitespace trimming for free:

  fn parse_integrity(value: &str) -> Result<MinIntegrity, String> {
      MinIntegrity::from_policy_str(value).ok_or_else(|| {
          format!(
              "AllowOnly.min-integrity must be one of {}",
              policy_integrity::ORDER_LOW_TO_HIGH_PIPED
          )
      })
  }

• Add parse_integrity_accepts_mixed_case test covering "None", "APPROVED", and " merged " to document the newly inherited behaviour.

labels/response_items.rs — add baseline test coverage

Add a #[cfg(test)] module with three tests:

• unknown_tool_returns_empty — _ => {} catch-all returns an empty vec (not a panic)
• error_response_is_skipped — isError=true early-return guard is respected regardless of tool name (security boundary)
• search_repositories_private_repo_gets_private_label — private repos in search results receive a private: secrecy label

[Copilot]

Pull request overview

This PR reduces duplication in Rust guard policy parsing by delegating parse_integrity to the canonical MinIntegrity::from_policy_str implementation, and adds initial unit tests for the security-sensitive item-based response-labeling path.

Changes:

• Refactor parse_integrity to call MinIntegrity::from_policy_str (inheriting trim + case-insensitive parsing).
• Add a new parse_integrity_accepts_mixed_case test to document the newly accepted inputs.
• Add baseline label_response_items unit tests for unknown tools, isError=true responses, and private repo labeling in search_repositories.

Show a summary per file

File	Description
guards/github-guard/rust-guard/src/lib.rs	Simplifies integrity parsing by delegating to MinIntegrity::from_policy_str and adds a test for mixed-case/whitespace inputs.
guards/github-guard/rust-guard/src/labels/response_items.rs	Adds initial unit tests covering key response-item labeling behaviors (unknown tool, error response skip, private repo secrecy labeling).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1