Refactor auth/HMAC request rejection call sites to remove duplicated constants

[Copilot]

rejectRequest was repeatedly invoked with fixed "auth" category and fixed error-type tokens across auth and HMAC middleware, creating noisy 8-arg call sites and a refactor hazard. This change centralizes those constants behind thin, file-local wrappers while preserving existing behavior and response semantics.

• Auth middleware cleanup (internal/server/middleware.go)

  • Added rejectAuthRequest(w, r, status, code, msg, detail) wrapper.
  • Replaced 3 duplicated rejectRequest(..., "auth", "authentication_failed", detail) calls with the wrapper.

• HMAC middleware cleanup (internal/server/hmac.go)

  • Added rejectHMACRequest(w, r, status, code, msg, detail) wrapper.
  • Replaced 7 duplicated rejectRequest(..., "auth", "hmac_validation_failed", detail) calls with the wrapper.

• Outcome

  • Single source of truth per middleware for log category + runtime error type.
  • Shorter rejection call sites, with only variable fields (status/code/message/detail) at each branch.

func rejectHMACRequest(w http.ResponseWriter, r *http.Request, status int, code, msg, detail string) {
	rejectRequest(w, r, status, code, msg, "auth", "hmac_validation_failed", detail)
}

// before:
// rejectRequest(w, r, http.StatusUnauthorized, "unauthorized", "invalid HMAC signature", "auth", "hmac_validation_failed", "signature_mismatch")
// after:
rejectHMACRequest(w, r, http.StatusUnauthorized, "unauthorized", "invalid HMAC signature", "signature_mismatch")

[Copilot]

Pull request overview

This PR refactors repeated rejectRequest(...) call sites in the auth and HMAC middleware by introducing thin, unexported wrapper helpers that encapsulate the fixed "auth" log category and fixed runtime error type tokens, reducing duplication while preserving existing rejection behavior and HTTP response semantics.

Changes:

• Added rejectAuthRequest(...) in internal/server/middleware.go and replaced repeated auth rejection call sites with it.
• Added rejectHMACRequest(...) in internal/server/hmac.go and replaced repeated HMAC rejection call sites with it.

Show a summary per file

File	Description
internal/server/middleware.go	Introduces rejectAuthRequest helper and uses it for consistent auth rejection calls.
internal/server/hmac.go	Introduces rejectHMACRequest helper and uses it for consistent HMAC rejection calls.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0