Reconcile CONTRIBUTING.md with actual strutil deep-clone location#7326
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix incorrect package reference in CONTRIBUTING.md
Reconcile CONTRIBUTING.md with actual Jun 10, 2026
strutil deep-clone location
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns contributor documentation with the current repository layout by correctly documenting that JSON deep-clone helpers live under internal/strutil/ (and removing stale wording that implied a separate jsonutil area).
Changes:
- Updated the “Project Structure” tree entry for
internal/strutil/to explicitly include JSON deep-clone utilities. - Updated the “Key Directories” description for
internal/strutil/to match the corrected tree wording.
Show a summary per file
| File | Description |
|---|---|
| CONTRIBUTING.md | Updates project structure and key-directory descriptions to accurately reflect JSON deep-clone utilities under internal/strutil/. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly docs reconciliation flagged a mismatch between contributor docs and implementation:
internal/jsonutil/was documented despite not existing, while JSON deep-clone utilities are implemented underinternal/strutil/. This PR alignsCONTRIBUTING.mdwith the current code layout.Project structure correction
internal/strutil/entry in the tree to explicitly include JSON deep-clone utilities.Key directories correction
internal/strutil/description in the “Key Directories” section to include JSON deep-clone.jsonutilwording by using a single accurate description in both sections.