Refactor duplicated first-content-item rewrite logic in rewriteEnvelopeTextPayload

[Copilot]

rewriteEnvelopeTextPayload contained duplicated branch logic for rewriting content[0].text across []map[string]interface{} and []interface{} payload shapes. This change consolidates that behavior into shared helpers while preserving existing type-specific output behavior and failure conditions.

• Payload rewrite refactor

  • Extracted shared content mutation flow into rewriteFirstContentItem(contentValue, filteredText).
  • Centralized first-item map copy + "text" update in rewriteContentItemText(...).
  • Simplified rewriteEnvelopeTextPayload to delegate content handling and keep envelope-copy behavior unchanged.

• Behavioral guarantees kept explicit

  • Empty content still returns (nil, false).
  • []interface{} with non-map first element still returns (nil, false).
  • Shallow-copy semantics remain intact: original input maps/slices are not mutated.

• Focused coverage for new helper path

  • Added TestRewriteFirstContentItem cases for:
    • []map[string]interface{}
    • []interface{}
    • invalid []interface{} first element type

rewrittenContent, ok := rewriteFirstContentItem(contentValue, filteredText)
if !ok {
    return nil, false
}
rewrittenMap["content"] = rewrittenContent
return rewrittenMap, true

[Copilot]

Pull request overview

This PR refactors rewriteEnvelopeTextPayload’s duplicated logic for rewriting content[0].text across the two supported payload shapes ([]map[string]interface{} and []interface{}) by extracting shared helpers, while keeping the same success/failure conditions and shallow-copy (non-mutating) behavior.

Changes:

• Replaced the inlined type-switch rewrite logic in rewriteEnvelopeTextPayload with a call to rewriteFirstContentItem(...).
• Added rewriteFirstContentItem(...) and rewriteContentItemText(...) helpers to centralize first-item copy-and-rewrite behavior.
• Added targeted unit tests for the new helper path in TestRewriteFirstContentItem.

Show a summary per file

File	Description
internal/middleware/jqschema.go	Extracts shared “rewrite first content item text” logic into helpers and simplifies envelope rewriting to delegate to the helper.
internal/middleware/filter_rewrite_test.go	Adds focused unit tests validating helper behavior for both supported content slice shapes and an invalid first element case.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0