Add direct repo-scope fallback coverage in Rust guard#7274
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add direct unit tests for extract_repo_scope_with_query_fallback
Add direct repo-scope fallback coverage in Rust guard
Jun 9, 2026
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the Rust guard’s security-relevant repo-scope resolution by adding direct unit coverage for extract_repo_scope_with_query_fallback, and it simplifies repeated items_path option construction in response path labeling.
Changes:
- Add focused unit tests validating arg-vs-query repo-scope resolution behavior for
extract_repo_scope_with_query_fallback. - Refactor
items_pathconstruction inlabel_response_pathsto usethen_some(...)instead of repeatedif/elseblocks.
Show a summary per file
| File | Description |
|---|---|
| guards/github-guard/rust-guard/src/labels/response_paths.rs | Replaces repeated items_path empty-check branching with then_some to reduce duplication while preserving behavior. |
| guards/github-guard/rust-guard/src/labels/helpers.rs | Adds direct unit tests for repo-scope resolution logic used by issue/PR collection labeling. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Contributor
Author
Fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_repo_scope_with_query_fallbackis security-relevant for issue and PR collection labeling, but only had indirect coverage through larger response-labeling tests. This change adds direct coverage for its arg-vs-query resolution behavior and simplifies duplicateditems_pathhandling inresponse_paths.rs.Direct coverage for repo-scope fallback
extract_repo_scope_with_query_fallback:owner/repowins overqueryquerywhen args are absentquerywhen args are partialIdiomatic
items_pathconstructionif items_path.is_empty() { None } else { Some(items_path) }blocks withthen_some(...)Example