refactor(proxy/router): extract repoMethodArgs/repoMethodResourceArgs helpers to eliminate Actions route duplication#7211
Merged
Conversation
7 tasks
…duce Actions route duplication
Copilot
AI
changed the title
[WIP] Refactor duplicate extractArgs closures in Actions route
refactor(proxy/router): extract repoMethodArgs/repoMethodResourceArgs helpers to eliminate Actions route duplication
Jun 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors internal/proxy/router.go to reduce duplication in the GitHub Actions routes by extracting small helper functions that build the owner/repo/method (+ optional resource_id) argument maps used when routing REST paths to guard tool invocations.
Changes:
- Added
repoMethodArgs(owner, repo, method)helper for Actions routes that don’t require aresource_id. - Added
repoMethodResourceArgs(owner, repo, method, resourceID)helper for Actions routes that capture a path segment intoresource_id. - Updated the Actions routes to use these helpers instead of repeated inline
map[string]interface{}literals.
Show a summary per file
| File | Description |
|---|---|
| internal/proxy/router.go | Adds helper constructors for route argument maps and applies them to Actions routes to remove repeated inline literals. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Actions routes block in
internal/proxy/router.gocontained ~14 near-identicalextractArgsclosures differing only inmethodandresource_idstring values — ~80 lines of copy-paste that increases bug risk and maintenance cost.Changes
New helpers alongside existing
repoArgs:repoMethodArgs(owner, repo, method)— for routes with noresource_idrepoMethodResourceArgs(owner, repo, method, resourceID)— for routes that capture a path segment asresource_idUpdated Actions routes (lines 200–306): replaced all inlined
map[string]interface{}literals with calls to the appropriate helper. The twoget_job_logsentries usingrun_idare unchanged as they don't fit the pattern.