refactor: eliminate duplicate extractArgs closures in proxy/router.go

[Copilot]

internal/proxy/router.go had ~40 lines of repeated extractArgs boilerplate across 23 route entries — identical anonymous functions wrapping the same map literals.

Changes

Adds four shared helpers alongside the existing repoArgs function:

• prArgs(owner, repo, pullNumber, method string) — builds PR args map; replaces 4 inline literals
• issueArgs(owner, repo, issueNumber string, method ...string) — builds issue args map with optional method; replaces 3 inline literals
• emptyExtractArgs — shared closure returning map[string]interface{}{}; replaces 6 identical anonymous funcs
• repoArgsExtractor — shared closure returning repoArgs(m[1], m[2]); replaces 10 identical anonymous func wrappers

Routes that previously needed a wrapper closure just to call repoArgs or return an empty map now reference the shared variable directly:

// Before
{
    pattern:  regexp.MustCompile(`^/repos/([^/]+)/([^/]+)/issues$`),
    toolName: "list_issues",
    extractArgs: func(m []string) map[string]interface{} {
        return repoArgs(m[1], m[2])
    },
},

// After
{
    pattern:     regexp.MustCompile(`^/repos/([^/]+)/([^/]+)/issues$`),
    toolName:    "list_issues",
    extractArgs: repoArgsExtractor,
},

Routes that build richer maps (PR, issue) now delegate to typed helpers instead of open-coded map literals:

// Before
extractArgs: func(m []string) map[string]interface{} {
    return map[string]interface{}{"owner": m[1], "repo": m[2], "pullNumber": m[3], "method": "get_files"}
},

// After
extractArgs: func(m []string) map[string]interface{} {
    return prArgs(m[1], m[2], m[3], "get_files")
},

Note: The "pullNumber" / "issue_number" key name asymmetry is pre-existing and intentional — these names are dictated by the downstream MCP tool interfaces and cannot be changed without coordinated guard updates.

[Copilot]

Pull request overview

This PR refactors internal/proxy/router.go to remove repeated extractArgs anonymous functions across many REST route entries by introducing shared helper functions/closures for common argument maps.

Changes:

• Added prArgs(...) and issueArgs(...) helpers to centralize construction of common PR/issue argument maps.
• Introduced shared extractArgs implementations for “no args” routes and “owner/repo only” routes, and reused them across route entries.
• Updated affected routes to reference these helpers instead of repeating inline map literals/closures.

Show a summary per file

File	Description
internal/proxy/router.go	Deduplicates repeated extractArgs closures/map literals via shared helpers and shared extractors in the route table.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 2

[lpcox]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Merged main into the PR branch. The conflict was in the helper function block — both branches added new helpers in the same area. The resolution keeps all of them: prArgs, issueArgs, emptyExtractArgs, and repoArgsExtractor from this PR, plus repoMethodArgs and repoMethodResourceArgs from main. Build and tests pass.