rust-guard: extract item_has_config_label helper + simplify get_string_field

[Copilot]

Two small refactors in guards/github-guard/rust-guard/src/labels/helpers.rs to eliminate duplicated extraction logic with no behaviour change.

Changes

• Extract item_has_config_label private helper — has_promotion_label and has_demotion_label shared an identical three-step body (empty-guard → extract labels → case-insensitive match). Both now delegate to a single private helper; any future change to matching semantics is a one-site edit.

fn item_has_config_label(item: &Value, config_label: &str) -> bool {
    if config_label.is_empty() { return false; }
    extract_github_label_names(item)
        .iter()
        .any(|name| config_label.eq_ignore_ascii_case(name))
}

pub fn has_promotion_label(item: &Value, ctx: &PolicyContext) -> bool {
    item_has_config_label(item, &ctx.promotion_label)
}
pub fn has_demotion_label(item: &Value, ctx: &PolicyContext) -> bool {
    item_has_config_label(item, &ctx.demotion_label)
}

• Simplify get_string_field — body reduced to a single delegation to the already-present get_str_or, giving the extraction chain one authoritative implementation.

pub fn get_string_field(value: &Value, field: &str) -> String {
    get_str_or(value, field, "").to_string()
}

[Copilot]

Pull request overview

This PR performs two small internal refactors in guards/github-guard/rust-guard/src/labels/helpers.rs to reduce duplicated JSON/label extraction logic while preserving existing behavior in the GitHub guard label helpers.

Changes:

• Extracted a private item_has_config_label helper to centralize case-insensitive matching for promotion/demotion label checks (including the “empty config disables feature” behavior).
• Simplified get_string_field to delegate to the existing get_str_or helper for a single authoritative string-extraction implementation.

Show a summary per file

File	Description
guards/github-guard/rust-guard/src/labels/helpers.rs	Deduplicates configured-label matching logic and simplifies string field extraction via existing helper.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0