[log] Add debug logging to difc/reflect.go#7173
Merged
Merged
Conversation
Add a logReflect logger (difc:reflect namespace) to BuildReflectResponse to help troubleshoot DIFC label reflection issues. The new log calls trace: - Entry with current enforcement mode - Count of registered agents before iterating - Any agents skipped due to missing/nil registry entries - Completion summary with reflected agent count and mode Also adds an explicit else-branch log when no AgentRegistry is configured, improving visibility into DIFC component initialization state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds DIFC debug logging to the /reflect response builder so operators can understand why zero (or fewer-than-expected) agents are reflected at runtime (e.g., nil registry vs empty registry vs missing agents).
Changes:
- Introduces a new debug logger namespace
difc:reflect. - Adds debug log lines in
BuildReflectResponsefor entry, registry size, skipped agents, nil-registry case, and completion.
Show a summary per file
| File | Description |
|---|---|
| internal/difc/reflect.go | Adds a difc:reflect debug logger and instrumentation in BuildReflectResponse to improve observability of reflect behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
6 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
logReflectdebug logger (namespacedifc:reflect) tointernal/difc/reflect.go.Changes
File modified:
internal/difc/reflect.govar logReflect = logger.New("difc:reflect")following thepkg:filenameconvention used across thedifcpackageBuildReflectResponse:strict,filter,propagate)*AgentLabels(was silentlycontinued before)elsebranch whenAgentRegistry == nilWhy
BuildReflectResponseis called by the/reflectendpoint to snapshot all agent DIFC labels. Without logging it was impossible to tell at debug time whether zero agents were reflected because the registry was empty, nil, or because agents failed lookups. These log calls (controlled byDEBUG=difc:reflectorDEBUG=difc:*) provide that visibility with zero overhead when the debug logger is disabled.Validation
make agent-finishedpassed: format ✓, build ✓, lint ✓, all Go tests ✓ (unit + integration)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
index.crates.ioSee Network Configuration for more information.