refactor(mcp): extract withReconnectLock to eliminate reconnect boilerplate

[Copilot]

reconnectPlainJSON and reconnectSDKTransport shared identical lock/log/error-wrap scaffolding, requiring any change to the reconnect lifecycle to be applied in two places.

Changes

• New withReconnectLock helper (connection.go) — acquires the session write lock, emits the reconnect log, calls logReconnectStart/logReconnectResult, and wraps errors uniformly; accepts the transport-specific logic as a func() error closure
• reconnectPlainJSON — reduced to a withReconnectLock("plain JSON-RPC", ...) call containing only the session-init and ID assignment logic
• reconnectSDKTransport — reduced to a withReconnectLock(fmt.Sprintf("SDK transport (type=%s)", ...), ...) call containing only transport construction and session connect logic; the default branch now also flows through the shared epilogue (logging + wrapping), which is a minor improvement

func (c *Connection) withReconnectLock(transportName string, reconnect func() error) error {
    c.sessionMu.Lock()
    defer c.sessionMu.Unlock()
    logConn.Printf("Session expired, reconnecting %s for serverID=%s", transportName, c.serverID)
    c.logReconnectStart()
    err := reconnect()
    c.logReconnectResult(err)
    if err != nil {
        return fmt.Errorf("session reconnect failed: %w", err)
    }
    return nil
}

[Copilot]

Pull request overview

This PR refactors MCP HTTP session reconnection logic by extracting the shared session-locking + reconnect-logging + error-wrapping scaffolding into a single helper, reducing duplicated reconnect boilerplate and ensuring consistent reconnect telemetry/error handling across transports.

Changes:

• Added (*Connection).withReconnectLock(...) to centralize session write-locking, reconnect start/result logging, and uniform error wrapping.
• Simplified reconnectPlainJSON to only perform HTTP session initialization + session ID assignment inside the helper closure.
• Simplified reconnectSDKTransport to only perform SDK transport construction + connect logic inside the helper closure, and ensured the default/unsupported transport branch now gets consistent logging/wrapping.

Show a summary per file

File	Description
internal/mcp/connection.go	Extracts shared reconnect lock/log/error epilogue into withReconnectLock and rewrites both reconnect paths to use it.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0