Skip to content

[log] Add debug logging to tracing/provider.go#7010

Merged
lpcox merged 1 commit into
mainfrom
log/tracing-provider-debug-logging-dd2d64ad8c93ec97
Jun 5, 2026
Merged

[log] Add debug logging to tracing/provider.go#7010
lpcox merged 1 commit into
mainfrom
log/tracing-provider-debug-logging-dd2d64ad8c93ec97

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Adds 5 meaningful debug log calls to internal/tracing/provider.go using the existing logTracing logger (logger.New("tracing:provider")).

Changes

Location Log added
Shutdown() Logs before flushing/shutting down the OTLP SDK provider
registerPropagator() Logs W3C TraceContext+Baggage propagator registration
InitProvider() — after exporter creation Logs successful OTLP HTTP exporter creation
InitProvider() — sampler selection Logs which sampler is chosen: AlwaysSample, NeverSample, or TraceIDRatioBased (with rate)

Why these spots?

  • Shutdown — previously silent; useful to confirm the SDK provider is actually being flushed on exit vs the noop path.
  • registerPropagator — called unconditionally on every InitProvider call (even when tracing is disabled); logging confirms the W3C propagator is registered so incoming traceparent headers are honoured.
  • Exporter creation — the failure path was already logged; this adds the success path.
  • Sampler selection — a three-branch switch with no visibility; helps diagnose unexpected sampling behaviour when sampleRate is near 0 or 1.

Validation

  • make agent-finished ran: format ✓, build ✓, lint ✓, all Go tests ✓ (Rust tests skipped — network firewall blocks crates.io in this environment).

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • index.crates.io

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "index.crates.io"

See Network Configuration for more information.

Generated by Go Logger Enhancement · sonnet46 5M ·

Add 5 meaningful debug log calls to internal/tracing/provider.go using the
existing logTracing logger:

- Shutdown: log before flushing and shutting down the OTLP SDK provider
- registerPropagator: log W3C TraceContext+Baggage propagator registration
- InitProvider: log after OTLP HTTP exporter is created successfully
- InitProvider: log which sampler was selected (AlwaysSample, NeverSample,
  or TraceIDRatioBased with the configured rate)

These additions help trace the tracing initialization path and diagnose
issues with OTLP configuration at startup and shutdown.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added automation enhancement New feature or request labels Jun 4, 2026
@lpcox lpcox marked this pull request as ready for review June 5, 2026 13:48
Copilot AI review requested due to automatic review settings June 5, 2026 13:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds additional debug-level observability to the OpenTelemetry tracing provider initialization and shutdown path, using the existing logTracing debug logger (logger.New("tracing:provider")) to make tracer/provider state transitions easier to diagnose when DEBUG is enabled.

Changes:

  • Log when the OTLP tracer provider is being flushed and shut down (non-noop path).
  • Log global W3C TraceContext + Baggage propagator registration.
  • Log successful OTLP HTTP exporter creation and which sampler branch was selected (including rate for ratio-based sampling).
Show a summary per file
File Description
internal/tracing/provider.go Adds 5 debug log calls around OTLP provider lifecycle, propagator registration, exporter creation, and sampler selection.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@lpcox lpcox merged commit c37a98e into main Jun 5, 2026
23 checks passed
@lpcox lpcox deleted the log/tracing-provider-debug-logging-dd2d64ad8c93ec97 branch June 5, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants