[log] Add debug logging to tracing/provider.go#7010
Merged
Conversation
Add 5 meaningful debug log calls to internal/tracing/provider.go using the existing logTracing logger: - Shutdown: log before flushing and shutting down the OTLP SDK provider - registerPropagator: log W3C TraceContext+Baggage propagator registration - InitProvider: log after OTLP HTTP exporter is created successfully - InitProvider: log which sampler was selected (AlwaysSample, NeverSample, or TraceIDRatioBased with the configured rate) These additions help trace the tracing initialization path and diagnose issues with OTLP configuration at startup and shutdown. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional debug-level observability to the OpenTelemetry tracing provider initialization and shutdown path, using the existing logTracing debug logger (logger.New("tracing:provider")) to make tracer/provider state transitions easier to diagnose when DEBUG is enabled.
Changes:
- Log when the OTLP tracer provider is being flushed and shut down (non-noop path).
- Log global W3C TraceContext + Baggage propagator registration.
- Log successful OTLP HTTP exporter creation and which sampler branch was selected (including rate for ratio-based sampling).
Show a summary per file
| File | Description |
|---|---|
| internal/tracing/provider.go | Adds 5 debug log calls around OTLP provider lifecycle, propagator registration, exporter creation, and sampler selection. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 5 meaningful debug log calls to
internal/tracing/provider.gousing the existinglogTracinglogger (logger.New("tracing:provider")).Changes
Shutdown()registerPropagator()InitProvider()— after exporter creationInitProvider()— sampler selectionAlwaysSample,NeverSample, orTraceIDRatioBased(with rate)Why these spots?
Shutdown— previously silent; useful to confirm the SDK provider is actually being flushed on exit vs the noop path.registerPropagator— called unconditionally on everyInitProvidercall (even when tracing is disabled); logging confirms the W3C propagator is registered so incomingtraceparentheaders are honoured.sampleRateis near 0 or 1.Validation
make agent-finishedran: format ✓, build ✓, lint ✓, all Go tests ✓ (Rust tests skipped — network firewall blocks crates.io in this environment).Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
index.crates.ioSee Network Configuration for more information.