[log] Add debug logging to expandTracingVariables in config/expand.go#5138
Merged
Conversation
Add meaningful log calls to the expandTracingVariables function in internal/config/expand.go, which previously had no logging despite performing non-trivial config field expansion logic. The new log calls: - Log function entry with a summary of which fields are present - Log each individual field expansion (endpoint, traceId, spanId, headers) - Log function completion These use the existing logValidation logger (config:validation namespace) already used throughout config/expand.go and config/validation.go. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug logging to internal/config/expand.go’s expandTracingVariables helper so tracing-related ${VAR} expansion is easier to diagnose during config load (particularly the TOML path before validation), leveraging the existing config:validation debug logger used throughout the config package.
Changes:
- Log function entry with presence flags for each tracing field (endpoint, traceId, spanId, headers).
- Log after successful expansion of each non-empty tracing field.
- Log function completion.
Show a summary per file
| File | Description |
|---|---|
| internal/config/expand.go | Adds logValidation debug statements around tracing config variable expansion to improve observability during startup/config load. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds meaningful debug logging calls to the
expandTracingVariablesfunction ininternal/config/expand.go.Changes
The
expandTracingVariablesfunction previously had no log calls despite performing non-trivial variable expansion across multiple tracing config fields. The rest ofconfig/expand.goand its siblingconfig/validation.goalready use thelogValidationlogger extensively.New logging added:
hasEndpoint,hasTraceID,hasSpanID,hasHeaders)Why This File
logValidationlogger (config:validationnamespace) is already declared in the same package (config/validation.go), so no new logger declaration is neededexpandTracingVariablesis called for TOML-loaded configs during startup — logging here helps diagnose tracing misconfiguration where\$\{VAR}syntax is used in OpenTelemetry settingsValidation
go build✅go vet✅go test ./...✅ (pre-existingTestFetchAndFixSchema_NetworkErrornetwork failure unrelated to this change)Warning
The following domain was blocked by the firewall during workflow execution:
invalidhostthatdoesnotexist12345.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.