Refactor `writeConfigs` cleanup tests to remove duplicated config + tolerant-failure scaffolding by Copilot · Pull Request #5352 · github/gh-aw-firewall

Copilot · 2026-06-21T15:59:55Z

src/docker-manager-cleanup.test.ts repeated the same minimal WrapperConfig construction and identical writeConfigs try/catch blocks across multiple writeConfigs tests. This PR consolidates that pattern so tests focus on filesystem/permission assertions rather than setup boilerplate.

What changed
- Added a local createWriteConfig(overrides?) helper in the writeConfigs test block to centralize baseline config creation.
- Added a local writeConfigsAllowingFailure(config) helper to encapsulate the shared “allow failure, keep side-effect assertions” behavior.
- Replaced repeated inline config literals and try/catch blocks in the targeted tests (work dir creation, log dirs, config file checks, permission checks, proxyLogsDir variants, chroot-home and gemini-home precreation).
- Clarified helper/comment wording to avoid implying failures are always late.
- Corrected the squid.conf test comment to avoid claiming an incorrect write order.
Why this structure
- Keeps partial-success semantics in one place.
- Reduces repeated setup code and makes each test’s assertion intent easier to scan.

const createWriteConfig = (overrides: Partial<WrapperConfig> = {}): WrapperConfig => ({
  allowedDomains: ['github.com'],
  agentCommand: 'echo test',
  logLevel: 'info',
  keepContainers: false,
  workDir: getDir(),
  ...overrides,
});

const writeConfigsAllowingFailure = async (config: WrapperConfig): Promise<void> => {
  try {
    await writeConfigs(config);
  } catch {
    // Some tests assert side effects that may exist even when writeConfigs throws.
  }
};

Copilot

Pull request overview

This PR refactors src/docker-manager-cleanup.test.ts to reduce repeated WrapperConfig setup and repeated writeConfigs try/catch scaffolding, keeping the tests focused on filesystem side effects and permissions.

Changes:

Added createWriteConfig(overrides) helper to centralize baseline WrapperConfig construction for writeConfigs tests.
Added writeConfigsAllowingLateFailure(config) helper to consolidate the “ignore errors but keep side-effect assertions” pattern.
Updated multiple writeConfigs tests to use these helpers (work dir creation, log dirs, config file checks, permission checks, proxyLogsDir, and gemini/chroot-home precreation).

Show a summary per file

File	Description
src/docker-manager-cleanup.test.ts	Consolidates repeated config setup and error-tolerant `writeConfigs` invocation into local helpers to reduce boilerplate in cleanup/config tests.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 2

+    const writeConfigsAllowingLateFailure = async (config: WrapperConfig): Promise<void> => {
      try {
        await writeConfigs(config);
      } catch {
-        // Expected to fail if seccomp profile not found, but directories should still be created
+        // writeConfigs may fail late (e.g., seccomp/config writes), but earlier side effects should remain
      }


+      const config = createWriteConfig({ allowedDomains: ['github.com', 'example.com'] });
+      await writeConfigsAllowingLateFailure(config);

      // Verify squid.conf was created (it's created before seccomp check)


lpcox · 2026-06-21T17:25:24Z

@copilot address review feedback

Copilot · 2026-06-21T17:35:28Z

@copilot address review feedback

Addressed. I updated src/docker-manager-cleanup.test.ts to clarify failure semantics by renaming the helper to writeConfigsAllowingFailure with an accurate catch comment, and fixed the squid.conf assertion comment to avoid incorrect ordering claims. Commit: 24b1669.

github-actions · 2026-06-21T17:36:34Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-06-21T17:36:35Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-06-21T17:36:35Z

✅ Smoke Claude passed

github-actions · 2026-06-21T17:36:36Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-06-21T17:36:36Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-06-21T17:36:36Z

✅ Smoke Gemini completed. All facets verified. 💎

Testing GitHub MCP connectivity

github-actions · 2026-06-21T17:36:36Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-06-21T17:36:36Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-06-21T17:36:37Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-06-21T17:36:38Z

✅ Build Test Suite completed successfully!

github-actions · 2026-06-21T17:36:39Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-06-21T17:36:41Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-06-21T17:39:45Z

Smoke Test: Copilot BYOK (Direct Mode) — PASS ✅

✅ GitHub MCP connectivity verified
✅ GitHub.com connectivity (HTTP 200)
✅ File write/read test passed
✅ BYOK inference working (agent → api-proxy → api.githubcopilot.com)

Running in direct BYOK mode via COPILOT_PROVIDER_API_KEY with api-proxy sidecar. @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-06-21T17:39:47Z

🔬 Smoke Test Results

PR: Refactor writeConfigs cleanup tests to remove duplicated config + tolerant-failure scaffolding
Author: @Copilot | Assignees: @lpcox, @Copilot

Test	Result
GitHub MCP connectivity	✅
GitHub.com connectivity (HTTP 200)	✅
File write/read	⚠️ pre-step vars unexpanded

Overall: PASS (2/3 verified; file test skipped due to unexpanded workflow template vars)

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-21T17:40:04Z

Smoke Test Summary:

GitHub Connectivity: ❌ (SSL Error 35)
File Writing: ✅
Bash Tool: ✅
GitHub MCP: ✅ (Verified via safeoutputs)

PRs:

Pending
Pending

Overall Status: FAIL (Connectivity test failed)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

github-actions · 2026-06-21T17:40:16Z

🔬 Smoke Test: Copilot PAT Auth — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	⚠️ pre-step data unsubstituted

Auth mode: PAT (COPILOT_GITHUB_TOKEN)

cc @lpcox @Copilot

🔑 PAT report filed by Smoke Copilot PAT

github-actions · 2026-06-21T17:40:40Z

Smoke test results:

perf(security-guard): prioritize security-relevant files in PR diff build-test ready-for-aw smoke-claude smoke-codex smoke-copilot-byok smoke-copilot-byok-aoai-apikey smoke-copilot-byok-aoai-entra smoke-copilot-pat
fix(smoke-claude): raise turn budget to 8 and fix add_comment usage build-test ready-for-aw smoke-claude smoke-codex smoke-copilot-byok smoke-copilot-byok-aoai-apikey smoke-copilot-byok-aoai-entra
GitHub reads: ✅
Browser title: ✅
File write/read: ✅
Build: ✅
Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-06-21T17:41:10Z

🔭 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Status	Details
1. Module Loading	✅	`otel.js` loads cleanly; exports 14 symbols: `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`, plus internal helpers
2. Test Suite	✅	59/59 tests pass across `otel.test.js` and `otel-fanout.test.js`; 0 failures
3. Env Var Forwarding	✅	`api-proxy-service-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME` to the sidecar container
4. Token Tracker Integration	✅	`onUsage` callback present in `token-tracker-http.js` (lines 283, 324, 374) as the OTEL hook point
5. OTEL Diagnostics	✅	No OTLP endpoint configured → graceful degradation to `FileSpanExporter` (`/var/log/api-proxy/otel.jsonl`); no errors

All scenarios pass. The OTEL tracing integration is fully functional with correct span creation, token usage attributes, parent context propagation support, and graceful degradation when unconfigured.

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-06-21T17:41:44Z

Chroot Runtime Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ NO
Node.js	v24.16.0	v22.22.3	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Result: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

github-actions · 2026-06-21T17:42:07Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	1/1 passed	✅ PASS
Node.js	execa	✅	1/1 passed	✅ PASS
Node.js	p-limit	✅	1/1 passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5352 · 79.8 AIC · ⊞ 7.7K · ◷

github-actions · 2026-06-21T17:42:35Z

Smoke Test Results — FAIL ❌

Check	Result
Redis PING	❌ TCP timeout (port 6379 unreachable)
PostgreSQL pg_isready	❌ No response (port 5432 unreachable)
PostgreSQL SELECT 1	❌ Skipped (port unreachable)

host.docker.internal resolves to 172.17.0.1 but both service ports timed out at the TCP level. Service containers appear not to be running or ports are blocked.

Overall: FAIL

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-06-21T17:42:53Z

@Copilot @lpcox

Smoke test results:

GitHub MCP Testing: ✅
GitHub.com Connectivity: ✅
File Write/Read Test: ✅
BYOK Inference Test: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-06-21T17:43:39Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	97.85%	97.89%	📈 +0.04%
Statements	97.78%	97.82%	📈 +0.04%
Functions	99.50%	99.50%	➡️ +0.00%
Branches	93.55%	93.58%	📈 +0.03%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/workdir-setup.ts`	92.7% → 94.5% (+1.82%)	92.7% → 94.5% (+1.82%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-06-21T17:43:55Z

@lpcox @Copilot

Split docker-manager cleanup tests by concern ✅
Split api-proxy token parser tests by JSON, SSE, and normalization concerns ✅
GitHub.com connectivity ✅
File I/O ✅
BYOK inference ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

lpcox · 2026-06-21T18:04:21Z

@copilot resolve the merge conflicts in this pull request

…e-writeconfigs-tests # Conflicts: # src/docker-manager-cleanup.test.ts

Copilot · 2026-06-21T18:09:54Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts and completed the merge with origin/main in commit bcb795c.

Initial plan

e2c9b38

Copilot AI assigned Copilot and lpcox Jun 21, 2026

Copilot started work on behalf of lpcox June 21, 2026 16:03 View session

test: deduplicate writeConfigs setup in docker-manager cleanup tests

56d04d1

Copilot AI changed the title ~~[WIP] Refactor duplicated writeConfigs tests with shared helper~~ Refactor writeConfigs cleanup tests to remove duplicated config + tolerant-failure scaffolding Jun 21, 2026

Copilot finished work on behalf of lpcox June 21, 2026 16:06

Copilot AI requested a review from lpcox June 21, 2026 16:06

lpcox marked this pull request as ready for review June 21, 2026 17:12

Copilot AI review requested due to automatic review settings June 21, 2026 17:12

Copilot started reviewing on behalf of lpcox June 21, 2026 17:12 View session

Copilot AI reviewed Jun 21, 2026

View reviewed changes

Copilot started work on behalf of lpcox June 21, 2026 17:33 View session

test: clarify writeConfigs failure-tolerant helper wording

24b1669

lpcox added the ready-for-aw label Jun 21, 2026

Copilot finished work on behalf of lpcox June 21, 2026 17:35

github-actions Bot added smoke-claude smoke-copilot-byok labels Jun 21, 2026

github-actions Bot added the smoke-copilot label Jun 21, 2026

github-actions Bot added the smoke-gemini label Jun 21, 2026

github-actions Bot added the smoke-copilot-pat label Jun 21, 2026

github-actions Bot added the smoke-codex label Jun 21, 2026

github-actions Bot added the build-test label Jun 21, 2026

lpcox temporarily deployed to aoai-model June 21, 2026 17:42 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jun 21, 2026

lpcox deployed to aoai-model June 21, 2026 17:42 — with GitHub Actions Active

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jun 21, 2026

lpcox enabled auto-merge (squash) June 21, 2026 17:49

Copilot started work on behalf of lpcox June 21, 2026 18:04 View session

Merge remote-tracking branch 'origin/main' into copilot/duplicate-cod…

bcb795c

…e-writeconfigs-tests # Conflicts: # src/docker-manager-cleanup.test.ts

auto-merge was automatically disabled June 21, 2026 18:10
Head branch was pushed to by a user without write access

Copilot finished work on behalf of lpcox June 21, 2026 18:10

Conversation

Copilot AI commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

lpcox commented Jun 21, 2026

Uh oh!

Copilot AI commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026

🔬 Smoke Test Results

Uh oh!

github-actions Bot commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026

🔬 Smoke Test: Copilot PAT Auth — PASS

Uh oh!

github-actions Bot commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026

🔭 Smoke Test: API Proxy OpenTelemetry Tracing

Uh oh!

github-actions Bot commented Jun 21, 2026

Chroot Runtime Version Comparison

Uh oh!

github-actions Bot commented Jun 21, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented Jun 21, 2026

Smoke Test Results — FAIL ❌

Uh oh!

github-actions Bot commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jun 21, 2026

Copilot AI commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading