ZWJ sequences for custom images#124
Closed
Crissov wants to merge 10 commits into
Closed
Conversation
implements github#120 I'd welcome suggestions for alternative sequences
for some reason, `"tags": ["custom"]` fucked up /test/emoji_test.rb, so removing for now
`custom?()` relied on `raw` to be empty, which means there would be no Unicode representation at all, but we are introducing custom ZWJ sequences for that here
Author
|
This fails because the code currently expects all custom emojis to have no Unicode representation ( |
Contributor
|
Hi thanks for the suggestion! Why would it be useful to have ZJW sequences for custom emoji? How are people expected to input such sequences? |
Author
|
They would be copied in plain-text environments, i.e. while the Octocat cannot be shown, 🐱🐙 can and users would be able to guess or learn what is missing there. |
|
hg |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements #120
I'd welcome suggestions for alternative sequences