Bump node from 16 to 20#1104
Merged
Merged
Conversation
|
Just bumping this as I've switched to the new support for actions to run dependabot and spotted the warning about Node.js v16. |
pavera
approved these changes
May 9, 2024
bdragon
approved these changes
May 9, 2024
honeyankit
approved these changes
May 9, 2024
This was referenced May 9, 2024
Merged
jeffwidman
added a commit
that referenced
this pull request
Mar 21, 2025
`es6` is legacy because GitHub actions used to use `node12`, which didn't support some of the newer versions. But GitHub Actions is now on `node20`, which supports `es2022`, so it's safe to let Typescript compile using this much newer syntax. We bumped this particular action to node20 here: * #1104 I'm starting to see Dependabot PR's trying to bump dependencies that are erroring because they can't use newer javascript features, so bumping this unblocks them.
jeffwidman
added a commit
that referenced
this pull request
Mar 21, 2025
`es6` is legacy because GitHub actions used to use `node12`, which didn't support some of the newer versions. But GitHub Actions is now on `node20`, which supports `es2022`, so it's safe to let Typescript compile using this much newer syntax. We bumped this particular action to node20 here: * #1104 I'm starting to see Dependabot PR's trying to bump dependencies that are erroring because they can't use newer javascript features, so bumping this unblocks them.
|
This action should be updated to use Node 24 now (Node 20 is deprecated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the action to run with node 20.
This works, but before merging we need a strategy for supporting updates to older GHES versions running node 16.