[C#] Deduplicate OnDisposeCall and improve implementation#626
Merged
stephentoub merged 2 commits intomainfrom Mar 2, 2026
Merged
[C#] Deduplicate OnDisposeCall and improve implementation#626stephentoub merged 2 commits intomainfrom
stephentoub merged 2 commits intomainfrom
Conversation
…t.cs and Session.cs Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
stephentoub
approved these changes
Mar 2, 2026
Copilot stopped work on behalf of
stephentoub due to an error
March 2, 2026 14:00
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deduplicates disposable-helper implementations in the .NET SDK by centralizing the “run an action on dispose” pattern into a single reusable type, and switching Session’s event unsubscription to use it.
Changes:
- Introduced a standalone
ActionDisposablehelper with a thread-safe, idempotentDispose()implementation. - Removed the duplicated
ActionDisposableimplementation fromClient.cs. - Replaced
Session’s privateOnDisposeCallwithActionDisposablefor handler unsubscription.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Session.cs | Uses ActionDisposable to unsubscribe event handlers and removes the now-redundant private disposable type. |
| dotnet/src/Client.cs | Removes the inline ActionDisposable definition now that it’s centralized. |
| dotnet/src/ActionDisposable.cs | Adds the shared ActionDisposable implementation for use across the .NET SDK. |
SteveSandersonMS
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActionDisposableinClient.csandOnDisposeCallinSession.csActionDisposable.csas a standalone file with the better implementation fromClient.csActionDisposableclass definition fromClient.csOnDisposeCallusage inSession.cswithActionDisposabletsxin sandbox)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.