Java: CWE-532 sensitive info logging#3090
Merged
aschackmull merged 12 commits intogithub:masterfrom May 14, 2020
Merged
Conversation
|
|
luchua-bc
force-pushed
the
java-insert-sensitive-info-into-log
branch
from
329ba28 to
d932770
Compare
1 task
JLLeitschuh
reviewed
Mar 27, 2020
JLLeitschuh
reviewed
Mar 27, 2020
felicitymay
reviewed
May 4, 2020
Contributor
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
Thanks for including a query help file with your new query. It makes it much easier for everyone to understand what your query does 😄
I've added a few suggested changes for typos and clarity.
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
…rence so this isn't needed here.
aschackmull
requested changes
May 11, 2020
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
Some inline comments. Also, the ql file needs to be autoformatted to pass PR checks. If you have tested this query on some number of projects it would be nice if you could share a bit of what you learned from looking through the results.
1. Change the regex pattern from variable contains "url" to variable starts with "url" 2. Add the logging trace method to sink
aschackmull
requested changes
May 13, 2020
…ther variations are excluded
…ing::localTaintStep(node1, node2)
aschackmull
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third-party logging utilities like Log4J and SLF4J are widely used in Java projects. This PR adds a codeql check for writing sensitive information to debug logs.