Allow omitting the autobuild Action when build mode specified #2120
Merged
henrymercer merged 5 commits intomainfrom Feb 8, 2024
Merged
Conversation
angelapwen
previously approved these changes
Feb 7, 2024
Contributor
angelapwen
left a comment
angelapwen
left a comment
There was a problem hiding this comment.
Cool! I like how simple that test was 💖
henrymercer
force-pushed
the
henrymercer/no-autobuild-action-necessary-with-build-mode
branch
from
3bd00e8 to
f3ced61
Compare
Contributor
Author
|
@angelapwen I added a couple more tests for the other build modes. Would you mind taking another look? |
angelapwen
approved these changes
Feb 8, 2024
Contributor
angelapwen
left a comment
angelapwen
left a comment
There was a problem hiding this comment.
The new tests look good to me! Should this have a changelog note? Or will we wait for a general larger-scale announcement of the new build modes?
Contributor
Author
|
Right now, this is just for internal testing. Once we've finished testing, we can remove all the internal labels and add a changelog note with all the changes. |
henrymercer
deleted the
henrymercer/no-autobuild-action-necessary-with-build-mode
branch
8 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables users to omit the
autobuildAction when the build mode is specified and the CLI supports thetraceCommandUseBuildModefeature (available in CodeQL CLI 2.16.2 and later). This will remove redundancy and reduce the possibility for errors.Merge / deployment checklist