Externally contributed pull requests get stuck in loop fetching/refreshing

[jcansdale]

Versions

• GitHub Extension for Visual Studio version: v2.9.0.7614
• Visual Studio version: All

What happened

I opened and checked out a pull request that has been created by an external user (not originating from the local repository). The pull request detail pane got stuck in a loop where it would keep refreshing and fetching.

Steps to Reproduce

Steps to reproduce the behavior:

1. Clone https://github.com/mayerwin/vs-customize-window-title
2. Open pull request 47 from list
3. Checkout pull request
4. Pull request gets stuck in a fetch/refresh loop
5. Click refresh if loop hasn't started

Expected behavior

Pull request should load once and not continually fetch/refresh!

Screenshots

Logs

2019-05-01 10:25:29.710 [22120] DBUG [11] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:30.978 [22120] DBUG [17] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:30.997 [22120] DBUG [17] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:31.042 [22120] DBUG [18] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:32.301 [22120] DBUG [26] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:32.313 [22120] DBUG [26] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:32.404 [22120] DBUG [23] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:37.275 [22120] DBUG [06] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:37.280 [22120] DBUG [06] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:37.343 [22120] DBUG [11] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:41.895 [22120] DBUG [18] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:41.901 [22120] DBUG [18] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:42.099 [22120] DBUG [22] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:43.982 [22120] DBUG [22] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:43.996 [22120] DBUG [22] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:45.002 [22120] DBUG [11] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:47.335 [22120] DBUG [18] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:47.342 [22120] DBUG [18] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:47.544 [22120] DBUG [22] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed

Additional context

This doesn't happen on the previous v2.8.1.7307 version.

[Lexiphan]

This was not solved! Still refreshing in a loop.

[meaghanlewis]

@Lexiphan thanks for letting us know. Just to double check, you are using the latest version of the extension, v2.9.1.7781 right? If so, feel free to reopen this issue.

[jcansdale]

@Lexiphan,

I'm keen to get to the bottom of this if it still isn't working in the latest release. Could you click Extensions > Manage Extensions and check that you're running v2.9.1.7781?

I'm really hoping you're running an earlier version! 🤞