Replace commit author name with login#175
Merged
alexcanessa merged 1 commit intogithub-tools:masterfrom Jun 18, 2018
Merged
Conversation
GitHub markdown converts @-references with links to user profiles. Using the full author name means potentially including a space which breaks this linking behavior. Instead of the author name (Ex: Mario Tacke), this fix uses the author login (Ex: mariotacke) to form a proper link in the release notes and changelog). This fixes github-tools#158
Contributor
Author
|
The build completed fine on Node 7.9 and 8. The Node 6 runner timed out on TravisCI. Please re-run to get a passing build. |
alexcanessa
approved these changes
Jun 18, 2018
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
===========================================
- Coverage 84.34% 38.26% -46.09%
===========================================
Files 7 7
Lines 345 345
===========================================
- Hits 291 132 -159
- Misses 54 213 +159
Continue to review full report at Codecov.
|
Member
|
@all-contributors please add @mariotacke for code |
Contributor
|
I've put up a pull request to add @mariotacke! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub markdown converts @-references with links to user profiles. Using
the full author name means potentially including a space which breaks this
linking behavior. Instead of the author name (Ex: Mario Tacke), this fix
uses the author login (Ex: mariotacke) to form a proper link in the
release notes and changelog).
This fixes #158