doc: small formatting fix#330
Conversation
Welcome to GitGitGadgetHi @camsteffen, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests. Please make sure that this Pull Request has a good description, as it will be used as cover letter. Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:
It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code. Contributing the patchesBefore you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions. If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via: curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt |
|
@derrickstolee can I pick on you to give me permission to submit? |
|
/submit |
|
Error: User camsteffen is not permitted to use GitGitGadget |
|
/allow camsteffen |
|
User camsteffen is now allowed to use GitGitGadget. |
|
/submit |
|
Submitted as pull.330.git.gitgitgadget@gmail.com |
|
On the Git mailing list, Derrick Stolee wrote (reply to this): |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
| @@ -208,7 +208,7 @@ endif::git-rev-list[] | |||
| '%GP':: show the fingerprint of the primary key whose subkey was used | |||
There was a problem hiding this comment.
On the Git mailing list, Derrick Stolee wrote (reply to this):
On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote:
> From: Cameron Steffen <cam.steffen94@gmail.com>
>
> move an incorrectly placed backtick
The change below is simple enough, but we prefer using full sentences in the commit messages. This includes capitalization and punctuation.
Thanks,
-Stolee
> Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>
> ---
> Documentation/pretty-formats.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index 079598307a..b87e2e83e6 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -208,7 +208,7 @@ endif::git-rev-list[]
> '%GP':: show the fingerprint of the primary key whose subkey was used
> to sign a signed commit
> '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2
> - minutes ago`}; the format follows the rules described for the
> + minutes ago}`; the format follows the rules described for the
> `-g` option. The portion before the `@` is the refname as
> given on the command line (so `git log -g refs/heads/master`
> would yield `refs/heads/master@{0}`).
>
Move a closing backtick that was placed one character too soon. Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>
|
/submit |
|
Error: Ignoring PR with empty title and/or body |
|
/submit |
|
Submitted as pull.330.v2.git.gitgitgadget@gmail.com |
|
On the Git mailing list, Johannes Schindelin wrote (reply to this): |
| @@ -208,7 +208,7 @@ endif::git-rev-list[] | |||
| '%GP':: show the fingerprint of the primary key whose subkey was used | |||
There was a problem hiding this comment.
On the Git mailing list, Junio C Hamano wrote (reply to this):
"Cameron Steffen via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Cameron Steffen <cam.steffen94@gmail.com>
>
> Move a closing backtick that was placed one character too soon.
>
> Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>
> ---
> Documentation/pretty-formats.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for spotting and fixing. Will apply.
>
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index 079598307a..b87e2e83e6 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -208,7 +208,7 @@ endif::git-rev-list[]
> '%GP':: show the fingerprint of the primary key whose subkey was used
> to sign a signed commit
> '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2
> - minutes ago`}; the format follows the rules described for the
> + minutes ago}`; the format follows the rules described for the
> `-g` option. The portion before the `@` is the refname as
> given on the command line (so `git log -g refs/heads/master`
> would yield `refs/heads/master@{0}`).
|
This branch is now known as |
|
This patch series was integrated into pu via git@d7f9ce0. |
|
This patch series was integrated into pu via git@7259d91. |
|
This patch series was integrated into pu via git@93592da. |
|
This patch series was integrated into pu via git@a53b884. |
|
This patch series was integrated into pu via git@4470493. |
|
This patch series was integrated into pu via git@dc70ce7. |
|
This patch series was integrated into pu via git@24df5cd. |
|
This patch series was integrated into next via git@a29a425. |
|
This patch series was integrated into pu via git@0c05222. |
|
This patch series was integrated into pu via git@877d754. |
|
This patch series was integrated into pu via git@d1d1bd3. |
|
This patch series was integrated into pu via git@f2052f1. |
|
This patch series was integrated into pu via git@cb3ec6f. |
|
This patch series was integrated into next via git@cb3ec6f. |
|
This patch series was integrated into master via git@cb3ec6f. |
|
Closed via cb3ec6f. |
2 participants
Move a closing backtick that was placed one character too soon.