Skip to content

status: remove the empty line after hints#196

Closed
johnlinp wants to merge 1 commit into
gitgitgadget:nd/switch-and-restorefrom
johnlinp:fix-status-empty-line
Closed

status: remove the empty line after hints#196
johnlinp wants to merge 1 commit into
gitgitgadget:nd/switch-and-restorefrom
johnlinp:fix-status-empty-line

Conversation

@johnlinp

Copy link
Copy Markdown

Before this patch, there is inconsistency between the status
messages with hints and the ones without hints: there is an
empty line between the title and the file list if hints are
presented, but there isn't one if there are no hints.

This patch remove the inconsistency by removing the empty
lines even if hints are presented.

@johnlinp johnlinp force-pushed the fix-status-empty-line branch from 136ad4e to 468be8f Compare May 14, 2019 14:45
@gitgitgadget

gitgitgadget Bot commented May 14, 2019

Copy link
Copy Markdown

Welcome to GitGitGadget

Hi @johnlinp, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

@dscho

dscho commented May 15, 2019

Copy link
Copy Markdown
Member

/allow johnlinp

@gitgitgadget

gitgitgadget Bot commented May 15, 2019

Copy link
Copy Markdown

User johnlinp is now allowed to use GitGitGadget.

@johnlinp

Copy link
Copy Markdown
Author

Thank you @dscho!

@johnlinp

Copy link
Copy Markdown
Author

/submit

@gitgitgadget

gitgitgadget Bot commented May 15, 2019

Copy link
Copy Markdown

Submitted as pull.196.git.gitgitgadget@gmail.com

@dscho

dscho commented May 15, 2019

Copy link
Copy Markdown
Member

Thank you @dscho!

You're welcome! (In more than one sense 😄 )

Comment thread t/t7060-wtstatus.sh
Before this patch, there is inconsistency between the status
messages with hints and the ones without hints: there is an
empty line between the title and the file list if hints are
presented, but there isn't one if there are no hints.

This patch remove the inconsistency by removing the empty
lines even if hints are presented.

Signed-off-by: John Lin <johnlinp@gmail.com>
@johnlinp johnlinp force-pushed the fix-status-empty-line branch from 468be8f to 7dfb9a4 Compare May 31, 2019 03:24
@johnlinp

johnlinp commented Jun 1, 2019

Copy link
Copy Markdown
Author

/submit

@gitgitgadget

gitgitgadget Bot commented Jun 1, 2019

Copy link
Copy Markdown

Error: Refusing to submit a patch series that does not merge cleanly.

@dscho dscho changed the base branch from master to nd/switch-and-restore June 3, 2019 14:15
@johnlinp

johnlinp commented Jun 4, 2019

Copy link
Copy Markdown
Author

/submit

@gitgitgadget

gitgitgadget Bot commented Jun 4, 2019

Copy link
Copy Markdown

Submitted as pull.196.v2.git.gitgitgadget@gmail.com

@gitgitgadget

gitgitgadget Bot commented Jun 4, 2019

Copy link
Copy Markdown

This branch is now known as jl/status-reduce-vertical-blank.

@gitgitgadget

gitgitgadget Bot commented Jun 4, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@aeb4f90.

@gitgitgadget gitgitgadget Bot added the pu label Jun 4, 2019
@gitgitgadget

gitgitgadget Bot commented Jun 6, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@8e305d8.

@gitgitgadget

gitgitgadget Bot commented Jun 6, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@487c771.

@gitgitgadget

gitgitgadget Bot commented Jun 7, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@cdaf311.

@gitgitgadget

gitgitgadget Bot commented Jun 10, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@0e74942.

@gitgitgadget

gitgitgadget Bot commented Jun 12, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@dec0f53.

@gitgitgadget

gitgitgadget Bot commented Jun 13, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@c4e9a90.

@gitgitgadget

gitgitgadget Bot commented Jun 14, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@0578cc6.

@gitgitgadget

gitgitgadget Bot commented Jun 18, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@d5af61a.

@gitgitgadget

gitgitgadget Bot commented Jun 20, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@28bc238.

@gitgitgadget

gitgitgadget Bot commented Jun 20, 2019

Copy link
Copy Markdown

This patch series was integrated into pu via git@dfecfcb.

@dscho

dscho commented Nov 24, 2019

Copy link
Copy Markdown
Member

This actually made it into v2.23.0 as b2f5171...

@dscho dscho closed this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants