convert.c: replace "\e" escapes with "\033".#1786
Closed
jamill wants to merge 9 commits into
Closed
Conversation
Include protocol.h to define enum protocol_version. Signed-off-by: Beat Bolli <dev+git@drbeat.li> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Include iterator.h to define enum iterator_selection. Signed-off-by: Beat Bolli <dev+git@drbeat.li> Signed-off-by: Junio C Hamano <gitster@pobox.com>
The "\e" escape is not defined in ISO C. While on this line, add a missing space after the comma. Signed-off-by: Beat Bolli <dev+git@drbeat.li> Signed-off-by: Junio C Hamano <gitster@pobox.com>
The macro GIT_PATH_FUNC expands to a function definition that ends with a closing brace. Remove two extra semicolons. While at it, fix the example in path.h. Signed-off-by: Beat Bolli <dev+git@drbeat.li> Signed-off-by: Junio C Hamano <gitster@pobox.com>
ISO C forbids the conversion of void pointers to function pointers. Introduce a context struct that encapsulates the function pointer. Signed-off-by: Beat Bolli <dev+git@drbeat.li> Signed-off-by: Junio C Hamano <gitster@pobox.com>
In ISO C, char constants must be in the range -128..127. Change the BOM constants to char literals to avoid overflow. Signed-off-by: Beat Bolli <dev+git@drbeat.li> Signed-off-by: Junio C Hamano <gitster@pobox.com>
jeffhostetler
approved these changes
Aug 9, 2018
jeffhostetler
left a comment
jeffhostetler
left a comment
There was a problem hiding this comment.
I’ve already merged this into Microsoft/git.git. I didn’t thnik to do it here too. Thanks!
Member
|
How about merging That would make things more obvious, and also make the next rebase straight-forward... |
dscho
requested changes
Aug 9, 2018
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
I'd prefer to merge bb/pedantic directly, instead of cherry-picking manually (and risking merge conflicts during the next rebase).
jamill
force-pushed
the
msvc_warning_fix
branch
from
4137f82 to
c213af4
Compare
Author
|
#1788 is a direct merge of the bb/pedantic, as I don't think I can switch the source branch. If that is the preferred route, we can close this PR. |
Author
|
Superseded by #1788 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "\e" escape is not defined in ISO C.
While on this line, add a missing space after the comma.
Signed-off-by: Beat Bolli dev+git@drbeat.li
Signed-off-by: Junio C Hamano gitster@pobox.com