Migrate to shellless pipeline execution and harden job control#280
Open
ghantoos wants to merge 9 commits intopre-releasefrom
Open
Migrate to shellless pipeline execution and harden job control#280ghantoos wants to merge 9 commits intopre-releasefrom
ghantoos wants to merge 9 commits intopre-releasefrom
Conversation
Owner
ghantoos
commented
Apr 5, 2026
ghantoos
commented
- replace runtime shell -c execution with direct subprocess.Popen(shell=False) argv execution
- implement explicit shellless pipeline wiring and process-group aware signaling/timeout handling
- fail closed on unsupported runtime shell syntax (command/process substitution and redirections)
- update job-control helpers/tests for pipeline-member lifecycle and fg/bg signal behavior
- refresh path/command/security test expectations and add migration documentation
- replace runtime shell -c execution with direct subprocess.Popen(shell=False) argv execution - implement explicit shellless pipeline wiring and process-group aware signaling/timeout handling - fail closed on unsupported runtime shell syntax (command/process substitution and redirections) - update job-control helpers/tests for pipeline-member lifecycle and fg/bg signal behavior - refresh path/command/security test expectations and add migration documentation
Reorganize the default configuration template and the lshell manpage for clearer structure and option grouping, while keeping behavior unchanged.
Remove policy_commands from schema, runtime, diagnostics, and CLI config params; keep lshow always enabled; drop legacy policy_show shell shim; update docs/README/sample configs and unit tests to reflect removal.
- rename local manifest commands in justfile:\n - test-manifest-update\n - test-manifest-check\n- add manifest freshness enforcement to CI pytest workflow:\n - run python3 scripts/update_config_coverage_manifest.py --check before pytest\n- keep the manifest updater/check script and guard test flow as the single source of truth for manifest drift detection\n- ensures PRs fail when tests/config evolve without updating test/config_coverage_manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.