llava : fix memory leaks in minicpmv#9879
Closed
tc-mb wants to merge 2 commits into
Closed
Conversation
ngxson
requested changes
Oct 14, 2024
Contributor
Author
Cool, I am a staff of the MiniCPM-V team. if you need to refactor the MiniCPM-V series, feel free ask me for help. |
ngxson
changed the title
ngxson
approved these changes
Oct 16, 2024
ngxson
left a comment
ngxson
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. I'm re-running the CI. Will merge once it passes
|
Any update? |
1 task
This was referenced Jan 15, 2025
Contributor
Author
|
I will incorporate these changes in the new pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the code I previously implemented might have memory leaks. It would be difficult to detect this problem if I just executed the code once, but this bug was discovered by supporting the sever mode.
This pr is used to fix all known memory leak issues. After relatively long sever mode testing, it was determined that minicpmv had no other memory leak problems.