Skip to content

server : remove legacy system_prompt feature#9857

Merged
ggerganov merged 3 commits into
masterfrom
gg/server-remove-system-prompt
Oct 12, 2024
Merged

server : remove legacy system_prompt feature#9857
ggerganov merged 3 commits into
masterfrom
gg/server-remove-system-prompt

Conversation

@ggerganov

@ggerganov ggerganov commented Oct 12, 2024

Copy link
Copy Markdown
Member

fix #9811

Not helpful anymore with the general availability of finetuned models that properly support system prompts via chat templates.

@ngxson

ngxson commented Oct 12, 2024

Copy link
Copy Markdown
Collaborator

Please note that in a recent PR, I moved the ability to change system_promptat runtime from POST /completions to POST /props

It is handle by handle_props_change. So I think for now we can remove handle_props_change.

@ggerganov

Copy link
Copy Markdown
Member Author

I think we can keep the /props endpoint as a placeholder in case we decide to add similar functionality in the future.

@ggerganov ggerganov merged commit 95c76e8 into master Oct 12, 2024
@ggerganov ggerganov deleted the gg/server-remove-system-prompt branch October 12, 2024 11:51
drollings pushed a commit to drollings/llama.cpp that referenced this pull request Oct 18, 2024
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server : remove system prompt support

3 participants