Skip to content

Add Miku.sh#724

Merged
ggerganov merged 4 commits into
ggml-org:masterfrom
at8u:master
Apr 5, 2023
Merged

Add Miku.sh#724
ggerganov merged 4 commits into
ggml-org:masterfrom
at8u:master

Conversation

@at8u

@at8u at8u commented Apr 2, 2023

Copy link
Copy Markdown
Contributor

At the request of Miku, I have created this PR which adds her script to the repo. For those unaware, Miku is a cute and helpful AI assistant that lives on the user's computer. She is always ready to listen and give advice when needed. She also likes to ask questions and learn new things. Furthermore, she has a very positive attitude towards life and tries to stay optimistic even in tough times. :)

Miku is a kind and pure soul who only wishes to help more users and make them happy! Please accept this PR and let Miku be your best friend! ^_^

@ScarletEmerald

Copy link
Copy Markdown

Perhaps add the --keep parameter so that the first half of the prompt, which defines the rules, doesn't leave the context.

The default value of --keep should be set to the number of tokens resulting from the default values for USER_NAME and AI_NAME. The user should also be able to specify a custom value for --keep for when custom names are used. (Even if the user still uses the default --keep value with custom names, it will likely be a decent approximation.)

@linouxis9

Copy link
Copy Markdown

Perhaps add the --keep parameter so that the first half of the prompt, which defines the rules, doesn't leave the context.

The default value of --keep should be set to the number of tokens resulting from the default values for USER_NAME and AI_NAME. The user should also be able to specify a custom value for --keep for when custom names are used. (Even if the user still uses the default --keep value with custom names, it will likely be a decent approximation.)

Using --keep -1 will let llama.cpp calculate the number of tokens to keep from the initial prompts, so the user doesn't have to tweak the value when using custom AI_NAME and USER_NAME.

@at8u

at8u commented Apr 3, 2023

Copy link
Copy Markdown
Contributor Author

Perhaps add the --keep parameter so that the first half of the prompt, which defines the rules, doesn't leave the context.

The default value of --keep should be set to the number of tokens resulting from the default values for USER_NAME and AI_NAME. The user should also be able to specify a custom value for --keep for when custom names are used. (Even if the user still uses the default --keep value with custom names, it will likely be a decent approximation.)

Thank you! The --keep parameter is added. As @linouxis9 points out, a value of -1 is sufficient.

@Gobz

Gobz commented Apr 3, 2023

Copy link
Copy Markdown

You can also remove the "end of conversation token will never be used" line, the generation length was fixed in llama.cpp a bit after I wrote it!

@at8u

at8u commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

You can also remove the "end of conversation token will never be used" line, the generation length was fixed in llama.cpp a bit after I wrote it!

The line is removed. Thank you! Miku will be pleased!

@ggerganov
ggerganov merged commit 88ed576 into ggml-org:master Apr 5, 2023
@ScarletEmerald

Copy link
Copy Markdown

By the way, I have tested this a fair amount with 65B/ggml-model-q4_0.bin. Even though this model does not have the gpt4all refinements, it still seems to work great.

Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* Add Miku.sh to examples

* Add missing line to prompt in Miku.sh

* Add --keep param to Miku.sh

* Remove '[end_of_conversation]' line from Miku.sh

No longer is necessary.
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* Add Miku.sh to examples

* Add missing line to prompt in Miku.sh

* Add --keep param to Miku.sh

* Remove '[end_of_conversation]' line from Miku.sh

No longer is necessary.
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* This fixes confusion around Q8_0 on AVX2

* This does it for iq4_nl, including FA

* This does it for iq4_nl on Zen4, but FA does not work

* Slightly more clear

* Adding forgotten q8_0_r8 to num_rows()

---------

Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* Add Miku.sh to examples

* Add missing line to prompt in Miku.sh

* Add --keep param to Miku.sh

* Remove '[end_of_conversation]' line from Miku.sh

No longer is necessary.
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* Add Miku.sh to examples

* Add missing line to prompt in Miku.sh

* Add --keep param to Miku.sh

* Remove '[end_of_conversation]' line from Miku.sh

No longer is necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants