Skip to content

Fix gguf-convert-endian script#4037

Merged
KerfuffleV2 merged 2 commits into
masterfrom
fix-gguf-convert-endian
Nov 11, 2023
Merged

Fix gguf-convert-endian script#4037
KerfuffleV2 merged 2 commits into
masterfrom
fix-gguf-convert-endian

Conversation

@monatis

@monatis monatis commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator

Reported in this issue comment

@monatis monatis requested a review from KerfuffleV2 November 11, 2023 10:21
@monatis

monatis commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator Author

cc @chenqiny

@chenqiny

Copy link
Copy Markdown
Contributor

It's resolved. Thank you.

@KerfuffleV2 KerfuffleV2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for fixing that! I guess I messed it up when refactored those scripts to work with the Poetry package stuff.

All those linters and type checkers can catch the tiniest discrepancy in whitespace or whatever but can't warn me about something that simple and dumb? :(

@KerfuffleV2 KerfuffleV2 merged commit e86fc56 into master Nov 11, 2023
@monatis monatis deleted the fix-gguf-convert-endian branch November 11, 2023 16:14
@cebtenzzre

cebtenzzre commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator

All those linters and type checkers can catch the tiniest discrepancy in whitespace or whatever but can't warn me about something that simple and dumb? :(

mypy and pytype aren't so good with unbound variables, but pyright can catch them (and there may be a flake8 plugin that can do it too). It's not my favorite because it has a lot of false positives.

/home/jared/src/forks/llama.cpp/gguf-py/scripts/gguf-convert-endian.py
  /home/jared/src/forks/llama.cpp/gguf-py/scripts/gguf-convert-endian.py:34:23 - warning: "order" is possibly unbound (reportUnboundVariable)
  /home/jared/src/forks/llama.cpp/gguf-py/scripts/gguf-convert-endian.py:35:36 - warning: "order" is possibly unbound (reportUnboundVariable)
  /home/jared/src/forks/llama.cpp/gguf-py/scripts/gguf-convert-endian.py:45:67 - warning: "order" is possibly unbound (reportUnboundVariable)
  /home/jared/src/forks/llama.cpp/gguf-py/scripts/gguf-convert-endian.py:50:8 - warning: "order" is possibly unbound (reportUnboundVariable)
0 errors, 4 warnings, 0 informations

@chenqiny

Copy link
Copy Markdown
Contributor

I tested it with new generated llama2 7b model with convert.py and llama2 7b converted from convert script.

@KerfuffleV2

Copy link
Copy Markdown
Contributor

Are you letting the suspense build before you tell us whether the result of testing was success or failure? :) I'm on the edge of my seat! 或者说我都迫不及待啦!

@chenqiny

Copy link
Copy Markdown
Contributor

Are you letting the suspense build before you tell us whether the result of testing was success or failure? :) I'm on the edge of my seat! 或者说我都迫不及待啦!

I just built it with the pull request.

olexiyb pushed a commit to Sanctum-AI/llama.cpp that referenced this pull request Nov 23, 2023
* Fix gguf-convert-endian script

* Bump version and update description
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* Fix gguf-convert-endian script

* Bump version and update description
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* Fix gguf-convert-endian script

* Bump version and update description
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* Fix gguf-convert-endian script

* Bump version and update description
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* Fix gguf-convert-endian script

* Bump version and update description
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* Fix gguf-convert-endian script

* Bump version and update description
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* Fix gguf-convert-endian script

* Bump version and update description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants