Fixed color reset problem in interactive mode.#283
Merged
Conversation
…s ensure color reset.
j-f1
approved these changes
Mar 19, 2023
bitRAKE
added a commit
to bitRAKE/llama.cpp
that referenced
this pull request
Mar 19, 2023
sw
pushed a commit
that referenced
this pull request
Mar 19, 2023
* fix coloring of last `n_batch` of prompt, and refactor line input * forgot the newline that needs to be sent to the model * (per #283) try to force flush of color reset in SIGINT handler
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…s ensure color reset. (ggml-org#283)
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…ml-org#221) * fix coloring of last `n_batch` of prompt, and refactor line input * forgot the newline that needs to be sent to the model * (per ggml-org#283) try to force flush of color reset in SIGINT handler
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
* Make fused MoE reproducible As a bonus, peak performance at pp2048 with u_batch = 2048 is ~8% better. * Slightly better * Also do it for non-fused mul_mat_id --------- Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
…s ensure color reset. (ggml-org#283)
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
…ml-org#221) * fix coloring of last `n_batch` of prompt, and refactor line input * forgot the newline that needs to be sent to the model * (per ggml-org#283) try to force flush of color reset in SIGINT handler
wywen
pushed a commit
to wywen/llama.cpp
that referenced
this pull request
Jun 25, 2026
…_IO (rrl ggml-org#283) The rrl ggml-org#201 weight-tensor hook fired with (name, base, size). The crate's DIRECT_IO weight roller (ggml-org#283) needs to pread each paged weight straight from the GGUF, so extend the hook to also pass the buffer's file offset (= `first`, the min tensor data offset for the ctx; addr is the file-base mmap) and the source file's fd. The crate dup()s the fd during the call (valid at load; the loader closes its own at teardown). Additive: a null/3-arg-era hook is just not installed. No behaviour change when the hook is absent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In interactive mode:
Press CTRL+C, the program exits, but terminal color still remains blue.
To ensure color reset, let's print '\n' in sigint_handler.