vulkan: Apply bias before softmax in FA, to avoid overflow#24909
Merged
Conversation
github-actions
Bot
added
Vulkan
1 task
0cc4m
approved these changes
Jun 23, 2026
Contributor
|
@ggml-org/maintainers Another approval needed. |
ngxson
approved these changes
Jun 23, 2026
Geminihaha
pushed a commit
to Geminihaha/llama.cpp
that referenced
this pull request
Jun 25, 2026
papamoose
pushed a commit
to papamoose/llama.cpp
that referenced
this pull request
Jun 27, 2026
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
adromir
pushed a commit
to adromir/llama-cpp-turboquant
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Apply a bias in the scalar/cm1 FA paths to avoid fp16 overflow. Should fix leejet/stable-diffusion.cpp#1678.
This bias was already in the cm2 path. cm2 is still generating a bad image, but it appears to be related to conv2d rather than FA (works if I disable coopmat2 for conv2d).
Requirements