Skip to content

[SYCL] Support OP EXPM1, support all UT cases of FLOOR, TRUNC, ROUND#24363

Merged
ggerganov merged 3 commits into
ggml-org:masterfrom
arthw:support_op_expm1_floor_trunc_round
Jun 16, 2026
Merged

[SYCL] Support OP EXPM1, support all UT cases of FLOOR, TRUNC, ROUND#24363
ggerganov merged 3 commits into
ggml-org:masterfrom
arthw:support_op_expm1_floor_trunc_round

Conversation

@arthw

@arthw arthw commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Support OP EXPM1
Support all UT cases of OP: FLOOR, TRUNC, ROUND

Verified with related UT cases locally.

@arthw arthw requested a review from a team as a code owner June 9, 2026 14:17
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Jun 9, 2026

@CISC CISC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leaves unary_op_floor/round/trunc_kernel unused, you may want to clean those up?

Update ops.md/SYCL.csv.

@CISC

CISC commented Jun 9, 2026

Copy link
Copy Markdown
Member

Support all UT cases of OP: FLOOR, TRUNC, ROUND, GET_ROWS

No changes to GET_ROWS AFAICT?

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 10, 2026
@arthw

arthw commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@CISC
Updated as the comments:

  1. remove the unused functions.
  2. update the ops.md
  3. GET_ROWS is not impacted by this PR. It's supported all in base.

Thank you!

@CISC CISC added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Jun 10, 2026
@ggerganov

Copy link
Copy Markdown
Member

Need rebase

@ggerganov ggerganov removed the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Jun 15, 2026
@arthw arthw force-pushed the support_op_expm1_floor_trunc_round branch from 99e93de to a5fb638 Compare June 15, 2026 12:45
@arthw arthw added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Jun 16, 2026
@ggerganov ggerganov merged commit fdd1098 into ggml-org:master Jun 16, 2026
29 checks passed
papamoose pushed a commit to papamoose/llama.cpp that referenced this pull request Jun 27, 2026
…gml-org#24363)

* support OP EXPM1, support all UT cases of FLOOR, TRUNC, ROUND

* fix conflict

* rebase, support new UT case of repeat, concat
adrianhoehne pushed a commit to adrianhoehne/llama.cpp that referenced this pull request Jul 5, 2026
…gml-org#24363)

* support OP EXPM1, support all UT cases of FLOOR, TRUNC, ROUND

* fix conflict

* rebase, support new UT case of repeat, concat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants