vulkan: Wrong Index Variable in Inner Loop#23665
Merged
0cc4m merged 1 commit intoMay 28, 2026
Merged
Conversation
github-actions
Bot
added
Vulkan
jeffbolznv
approved these changes
May 25, 2026
jeffbolznv
left a comment
jeffbolznv
left a comment
Contributor
There was a problem hiding this comment.
I think this change is correct, though the function appears to be unused.
Contributor
Author
|
Yes it is unused at the moment but the function may still become useful in the future. |
0cc4m
approved these changes
May 28, 2026
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
May 28, 2026
fewtarius
pushed a commit
to fewtarius/CachyLLama
that referenced
this pull request
May 30, 2026
turbo-tan
pushed a commit
to turbo-tan/llama.cpp-tq3
that referenced
this pull request
Jun 2, 2026
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jun 23, 2026
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jun 23, 2026
This reverts commit afbb783.
zbrad
pushed a commit
to zbrad/llama.cpp
that referenced
this pull request
Jul 3, 2026
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jul 5, 2026
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jul 5, 2026
This reverts commit 74e5ecf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The source offset uses
i1*nb0inside the i0 loop instead ofi0*nb0. This causes incorrect source addresses for every element, producing garbage data in the non-contiguous tensor copy path.Additional information
Requirements