server : add slot_prompt_similarity getter/setter#22393
Open
bernardladenthin wants to merge 2 commits into
Open
server : add slot_prompt_similarity getter/setter#22393bernardladenthin wants to merge 2 commits into
bernardladenthin wants to merge 2 commits into
Conversation
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add public getter and setter methods for the
slot_prompt_similarityfield inserver_context.Changes
get_slot_prompt_similarity()const method to retrieve the current threshold value.set_slot_prompt_similarity(float value)method to update the threshold value.Additional information
This change exposes the slot-similarity configuration as part of the public
server_contextAPI, so callers can query and modify slot-selection behavior at runtime without reloading the model.The motivation is API parity for embedders. I'm refactoring bernardladenthin/java-llama.cpp using Claude Code to drop its hand-ported
server.hppand link upstream'sserver_contextdirectly. In the previous code path the JNI layer could update this threshold at runtime; with the new upstream API surface, that capability is no longer reachable, sinceslot_prompt_similaritylives inside the impl with no setter.I don't have a concrete operational use case beyond restoring the previous embedder behavior, and I'm happy to drop the PR if you'd rather keep the field strictly load-time configurable. If so, it might also make sense to drop this feature on the Java-binding side. Please give an suggestion.
Requirements
on_sleeping_changedpattern.