feat: migrate to PEP 621 and add uv support#21907
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Thanks, we're using In fact I think it is too much of a burden to maintain the lock files in general, if |
I agree, I feel like lockfiles in anything other than a deployment situation are highly overrated... I can remove it from the PR. |
|
What are the next steps here? |
It looks like |
CISC
left a comment
There was a problem hiding this comment.
Untested, let's hope this works. :)
| authors = [{name = "GGML", email = "ggml@ggml.ai"}] | ||
| requires-python = '>=3.10' | ||
| dependencies = [ | ||
| 'numpy (>=1.25.0,<2.0.0)', |
There was a problem hiding this comment.
This may also be the time to bump numpy, but we can leave that to a follow up.
|
I'm running some manual tests on macos, windows, and linux and ran into this issue #22753.
|
Overview
The
pyproject.tomlwas no longer valid, in particular becausetransformers==5.5.1does not actually support Python 3.9. This means that though Poetry insisted on runningpoetry lock, that command would always fail.Also, because it used Poetry-specific configuration, it was not usable with less broken build/package managers like
uvandhatch. Now that Poetry supports the PEP 621 standard for metadata, it is possible to interoperate.I have also add the proper configuration to use
uv, so you can now simply douv run llama-convert-hf-to-gguffrom the root directory and it will Just Work (I hope!). Yes, you can do this withpoetry runas well 😉Probably fixes #21536
Requirements