Skip to content

convert : allow quantizing lora again#17453

Merged
CISC merged 1 commit into
masterfrom
cisc/convert-lora-allow-quantize
Nov 24, 2025
Merged

convert : allow quantizing lora again#17453
CISC merged 1 commit into
masterfrom
cisc/convert-lora-allow-quantize

Conversation

@CISC

@CISC CISC commented Nov 23, 2025

Copy link
Copy Markdown
Member

Allow quantizing LoRA at conversion again, but default to F32 (as has been the norm since #8980 inadvertently forced this).

Fixes #17447
Fixes #10671

@CISC CISC merged commit b61de2b into master Nov 24, 2025
10 checks passed
@CISC CISC deleted the cisc/convert-lora-allow-quantize branch November 24, 2025 14:50
@ggerganov

Copy link
Copy Markdown
Member

Did this change somehow cause some of the CPU CI to start failing:

image

@ggerganov

Copy link
Copy Markdown
Member

@CISC For some reason this exception is not being caught when running in the CI:

https://github.com/ggml-org/llama.cpp/actions/runs/19645856267/job/56260791630#step:5:6742

Locally it is being caught and the execution proceeds normally. Any ideas?

@CISC

CISC commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

Did this change somehow cause some of the CPU CI to start failing:

I don't see how, must be something else.

@CISC For some reason this exception is not being caught when running in the CI:

https://github.com/ggml-org/llama.cpp/actions/runs/19645856267/job/56260791630#step:5:6742

Locally it is being caught and the execution proceeds normally. Any ideas?

Strange, I'll have a look...

@ggerganov

Copy link
Copy Markdown
Member

I traced it that transformers==4.57.2 breaks the conversion and throws the second exception in the log. Downgrading to transformers==4.57.1 resolves the problem.

@CISC

CISC commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

I traced it that transformers==4.57.2 breaks the conversion and throws the second exception in the log. Downgrading to transformers==4.57.1 resolves the problem.

Yeah, I just found that out too: huggingface/transformers#42378

@CISC

CISC commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

There will be a hotfix as soon as huggingface/transformers#42389 merges.

Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: convert_lora_to_gguf ignores outtype Misc. bug: convert_lora_to_gguf ignores outtype

3 participants