Skip to content

metal : use F32 attention accumulators in FA kernels#13975

Merged
ggerganov merged 1 commit into
masterfrom
gg/metal-fa-acc-f32
Jun 2, 2025
Merged

metal : use F32 attention accumulators in FA kernels#13975
ggerganov merged 1 commit into
masterfrom
gg/metal-fa-acc-f32

Conversation

@ggerganov

Copy link
Copy Markdown
Member

fix #12433 (comment)

It seems that the attention output lo overflows F16 at large context (more than 32k). This fixes Gemma 3 27B at large contexts with Metal.

@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) labels Jun 2, 2025
@ggerganov
ggerganov merged commit ea394d7 into master Jun 2, 2025
@ggerganov
ggerganov deleted the gg/metal-fa-acc-f32 branch June 2, 2025 18:33
furyhawk pushed a commit to furyhawk/llama.cpp that referenced this pull request Jun 6, 2025
@Animaxx

Animaxx commented Jun 8, 2025

Copy link
Copy Markdown

I think this change cause issue in M1, M2 iOS device #14055

Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apple Metal https://en.wikipedia.org/wiki/Metal_(API) ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: Gemma3 <unused32> spam

2 participants