fix: Vulkan shader gen binary path when not cross compiling#11149
Closed
giladgd wants to merge 1 commit into
Closed
fix: Vulkan shader gen binary path when not cross compiling#11149giladgd wants to merge 1 commit into
giladgd wants to merge 1 commit into
Conversation
github-actions
Bot
added
Vulkan
Contributor
Author
|
@ag2s20150909 Can you please check that this fix doesn't reintroduce the issue you were having with cross-compiling Vulkan? |
Collaborator
|
I don't think we need this PR after thinking about it more. The real problem we're dealing with is that when cross-compiling, |
Contributor
Author
|
@bandoti I agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11096 (comment).