fix(ci): accept CLA signature comment variants - #1730
Draft
xiaoyaner0201 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue_commentgate to accept the canonical signing sentence when CLA Assistant Lite appends its documented e-mail or company suffixrecheckpath and everypull_request_targetrun.github/workflows/cla.ymland exercises accepted and rejected event/body combinationsThe implementation deliberately does not set
custom-pr-sign-comment: at the pinned action revision, any nonempty custom signing comment switches the action's own matching to exact equality and would reject the existing suffix-bearing signatures once the workflow starts.Type of Change
Objective
This is the bounded trigger fix discussed in issue #1727. It changes only the workflow gate and adds its regression fence; it does not change the CLA document, signature ledger, action pin, permissions, tokens, or branch protection.
Issue checkpoint
Issue #1727 remains open. The pre-implementation checkpoint is #1727 (comment). At publication time, the live default branch was
mainataab852df94413fd0d55cbea2b7886173020281d5, and no existing PR used headxiaoyaner0201:fix/1727-cla-signature-trigger.This Draft intentionally references #1727 without an automatic-closing keyword. It must remain Draft and must not merge until maintainers review the contributor-governance behavior and required checks complete.
Testing
Focused verification on the exact published candidate:
GRAPHITI_TELEMETRY_ENABLED=false uv run pytest tests/test_cla_workflow.py -q— 1 passed; one unrelated Pydantic deprecation warninguv run ruff check tests/test_cla_workflow.py— passedgit diff --check aab852df94413fd0d55cbea2b7886173020281d5..HEAD— passedactionlint— unavailable/not installed locally, so no actionlint result is claimedPublished candidate identity:
5b995104dc9823573c178e6a53de5b032ba61cfd1ad7ceecdfdd0504203c36bbedc11a10af684837.github/workflows/cla.yml,tests/test_cla_workflow.pyGovernance and review limitation
This publication does not establish independent one-to-one governance review. The operational GitHub identity involved in the contribution/publication path may overlap with a repository governor or reviewer identity. Nothing in this Draft or its pre-publication technical verification is a public approval claim. A separate maintainer/CODEOWNER review and the repository's required approval/check rules remain necessary.
Breaking Changes
Checklist
ruff checkpasses)Related Issues
Related to #1727 (non-closing while Draft).