Closed
Conversation
|
Hate to be that guy, but kinda bumping this. Would love to see this PR progress. Can anyone take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Currently, SOPS doesn't redirect any signals to the child process when running in
exec-fileorexec-envmodes so the child process can't react to a signal (e.g.SIGHUPfor reloading orSIGTERM/SIGINTto shutdown graceful). Instead, SOPS shuts down without giving any chance to the child process.This PR causes SOPS to wait for the child process to finish first and redirect all the signals it receives to the child process. Also, child processes are created with different process group ID which means that only SOPS receives signals, and not both.
Fixes #840
Related #880