Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer in.Close() |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer out.Close() |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer tty.Close() |
Check warning
Code scanning / CodeQL
Writable file handle closed without error handling
zimbatm
approved these changes
Jun 2, 2024
Signed-off-by: Marvin Strangfeld <marvin@strangfeld.io>
|
@albinvass would you be willing to take a look at the current conflicts and resolve them, as felixfontein said that he could try to take a look at it and maybe do something about it, here: #1134 (review) Maybe there is a chance to finally have this merged :) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rebases and continues #1134