Improve integration tests: reformat test code, make sure exit codes are always checked#1390
Merged
felixfontein merged 3 commits intogetsops:mainfrom Dec 29, 2023
Merged
Improve integration tests: reformat test code, make sure exit codes are always checked#1390felixfontein merged 3 commits intogetsops:mainfrom
felixfontein merged 3 commits intogetsops:mainfrom
Conversation
This was referenced Dec 26, 2023
Merged
devstein
approved these changes
Dec 29, 2023
Contributor
devstein
left a comment
devstein
left a comment
There was a problem hiding this comment.
Makes sense to me. What you think about adding a CI check to enforce rustfmt? Happy to make an issue for tracking
Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
Contributor
Author
|
Adding a CI check definitely makes sense! It's so easy to apply formatting (simply run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.