gcpkms: Add support for oauth tokens using env var#1188
gcpkms: Add support for oauth tokens using env var#1188warwick-mitchell1 wants to merge 1 commit intogetsops:mainfrom
Conversation
Add support for CLOUDSDK_AUTH_ACCESS_TOKEN environment to pass though an oauth access token directly or via a file.
| credentials := []byte(envCredentials) | ||
| if _, err := os.Stat(envCredentials); err == nil { | ||
| if credentials, err = os.ReadFile(envCredentials); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Perhaps don't exit here, but instead check SopsGoogleCredentialsOAuthEnv as well?
There was a problem hiding this comment.
@warwick-mitchell1 I believe this is also done by the application default credentials: https://cloud.google.com/docs/authentication/application-default-credentials#search_order
There was a problem hiding this comment.
You maybe right, this isn't the part I'm really adding with this PR though, this was already like this. I'm adding the Oauth token below which isn't covered by application-defaultcreds
There was a problem hiding this comment.
I understand this. However, with your added functionality I believe it makes sense to also adjust the old behavior. If any fail condition happens with the credentials by file lookup, continue to check whether credentials by token area available before failing completely.
|
Couldn't find anything in the Google docs, but the Terraform provider documentation provides a few more (and different) environment variables: https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/provider_reference#authentication-configuration |
|
Let's do this! |
| if envToken, isSet := os.LookupEnv(SopsGoogleCredentialsOAuthEnv); isSet { | ||
| token := []byte(envToken) | ||
| if _, err := os.Stat(envToken); err == nil { | ||
| if token, err = os.ReadFile(envToken); err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
| tokenSource := oauth2.StaticTokenSource( | ||
| &oauth2.Token{AccessToken: string(token)}, | ||
| ) | ||
| return option.WithTokenSource(tokenSource), nil | ||
| } |
There was a problem hiding this comment.
I think we should not check for a file here, but rather assume what's documented in https://cloud.google.com/sdk/docs/authorizing. Which only mentions:
Set the
CLOUDSDK_AUTH_ACCESS_TOKENenvironment variable to the access token value.
|
are there any blockers for this? I currently also facing issues with SOPS using Googles access token. |
|
bumping this up, what's blocking it? need support for ODIC token auth |
|
@warwick-mitchell1 Do you plan on continuing the PR? |
|
It looks like #1578 is adding the same functionality. |
6 participants
Add support for CLOUDSDK_AUTH_ACCESS_TOKEN environment to pass though an oauth access token directly or via a file.