Skip to content

Basic anyhow integration - #165

Closed
repi wants to merge 4 commits into
getsentry:masterfrom
EmbarkStudios:anyhow
Closed

Basic anyhow integration#165
repi wants to merge 4 commits into
getsentry:masterfrom
EmbarkStudios:anyhow

Conversation

@repi

@repi repi commented Oct 29, 2019

Copy link
Copy Markdown

This adds an optional integration for the anyhow error crate that can be enabled with the with_anyhow feature.

It works very similar to the failure crate but does not here support backtraces, as anyhow only supports backtraces on nightly. One could implement support for nightly-only backtraces but we don't have a need for that so didn't do it in this PR.

Fix #162

@repi

repi commented Nov 11, 2019

Copy link
Copy Markdown
Author

Any feedback on the change? Something you would be able to integrate?

@quininer

Copy link
Copy Markdown

I understand that sentry has recently changed in open source, is sentry no longer accepting community contributions?

@repi

repi commented Nov 12, 2019

Copy link
Copy Markdown
Author

@quininer only the licensing for the server components changed: https://twitter.com/mitsuhiko/status/1192188542988038146. and sentry-rust is a client-side only library

@siedentop

Copy link
Copy Markdown

@repi could you please update the branch with the base branch?

@siedentop siedentop left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. And I have been successfully using this.

However, my Rust knowledge is not good enough to review the code.

Also, it would be great to have some tests here. Would you mind taking a look at this?

@repi

repi commented Feb 9, 2020

Copy link
Copy Markdown
Author

The maintainers of this repo have not given any feedback about this in 3 months, I will not do any further work on this. We have our own fork of sentry-rust that we use for now with this and additional changes.

@Tomcc

Tomcc commented May 3, 2020

Copy link
Copy Markdown

As of a few hours ago failure has been deprecated, so this issue probably became a lot more important.
sentry is the only crate preventing me from switching from failure to anyhow... I could always write my own integration, but it'd be nice to give this PR some more love instead :)

@Swatinem

Swatinem commented May 4, 2020

Copy link
Copy Markdown
Contributor

I’m making good progress with the internals, and will try to get to all the open PRs in the next few weeks :-)

@Swatinem

Copy link
Copy Markdown
Contributor

closing, as this was added in #212

@Swatinem Swatinem closed this May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

anyhow integration

5 participants