Ref(Sample): Add existing bundled playgroundscreen into sample app#5778
Open
lucas-zimerman wants to merge 2 commits intomainfrom
Open
Ref(Sample): Add existing bundled playgroundscreen into sample app#5778lucas-zimerman wants to merge 2 commits intomainfrom
lucas-zimerman wants to merge 2 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| <BottomTabNavigator.Screen | ||
| name="PlaygroundTab" | ||
| component={getPlaygroundTab()} | ||
| component={getPlaygroundTab(StackNavigator)} |
There was a problem hiding this comment.
Argument passed to getPlaygroundTab is silently ignored
Low Severity
getPlaygroundTab(StackNavigator) passes StackNavigator as an argument, but getPlaygroundTab is defined with no parameters — so the argument is silently ignored. The other two tab factories (getErrorsTab, getPerformanceTab) accept a Navigator: TypedNavigator<any, any> parameter and use it to create nested navigators, but getPlaygroundTab was never updated to match. This looks like an incomplete refactoring step and could mislead future developers.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
On the playground area, I added a new button to interact with the existing playground that exists within the SDK.
💚 How did you test it?
Running the sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps