chore(deps): update Android SDK to v8.34.0#5760
chore(deps): update Android SDK to v8.34.0#5760github-actions[bot] wants to merge 4 commits intomainfrom
Conversation
df3ec14 to
89d3a17
Compare
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| api 'io.sentry:sentry-android:8.33.0' | ||
| debugImplementation 'io.sentry:sentry-spotlight:8.33.0' | ||
| api 'io.sentry:sentry-android:8.34.0' | ||
| debugImplementation 'io.sentry:sentry-spotlight:8.34.0' |
There was a problem hiding this comment.
Stale no-op bridge methods now implementable after SDK bump
Low Severity
Flagging this per the dependency update review rule. The v8.34.0 changelog introduces scope-level attributes API (Sentry.setAttribute, Sentry.setAttributes, Sentry.removeAttribute), but the native bridge methods setAttribute and setAttributes in RNSentryModuleImpl.java remain as no-ops with stale TODO comments reading "This is not implemented in sentry-android yet." The version bump requires corresponding bridge code updates to actually forward these calls to the now-available Android SDK APIs.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
89d3a17 to
374b97e
Compare
374b97e to
f95d813
Compare
* chore: update scripts/update-android-stubs.sh to 8.34.0 * Update stub --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
antonis
left a comment
There was a problem hiding this comment.
Marking as Blocked due to the sentry-android gradle plugin version mismatch and to support attributes properly following up on #5579 /cc @alwx


Bumps scripts/update-android.sh from 8.33.0 to 8.34.0.
Auto-generated by a dependency updater.
Changelog
8.34.0
Features
Sentry.setAttribute,Sentry.setAttributes,Sentry.removeAttributeSENTRY_SAMPLE_RATEenvironment variable /sample-rateproperty (#5112)sentry-opentelemetry-otlpandsentry-opentelemetry-otlp-springmodules for combining OpenTelemetry SDK OTLP export with Sentry SDK (#5100)OpenTelemetryOtlpEventProcessor) but will not send spans through OpenTelemetry nor use OpenTelemetryContextforScopespropagation.sentry-android-replaymodule to be present at runtime for masking to workAndroidManifest.xml:ManifestMetaDataReadernow read theDIST(#5107)Fixes
Long,Short,Byte,BigInteger,AtomicInteger, andAtomicLongbeing incorrectly inferred asdoubleinstead ofinteger(#5122)AndroidRuntimeManagerStrictMode relaxation to prevent ANRs during SDK init (#5127)SystemEventsBroadcastReceiverwith try-catch block. (#5106)peekDecorViewinstead ofgetDecorViewinSentryGestureListenerto avoid forcing view hierarchy construction (#5134)network_errortosend_errorURISyntaxExceptioncaused by trailing whitespace (#5113)Sentry.init(#5135)Dependencies