fix(tanstackstart-react): Flush events in server entry point for serverless environments#19513
Open
nicohrubec wants to merge 2 commits intodevelopfrom
Open
fix(tanstackstart-react): Flush events in server entry point for serverless environments#19513nicohrubec wants to merge 2 commits intodevelopfrom
nicohrubec wants to merge 2 commits intodevelopfrom
Conversation
…erless environments
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…is done executing
JPeer264
reviewed
Feb 25, 2026
| attributes: serverFunctionSpanAttributes, | ||
| }, | ||
| async () => { | ||
| // eslint-disable-next-line no-return-await |
Member
There was a problem hiding this comment.
l: You can leave it as it was before and remove this eslint-disable comment
Member
Author
There was a problem hiding this comment.
are you sure that works? I read that it actually matters to await returned promises within try/catch blocks, e.g. https://typescript-eslint.io/rules/return-await/#:~:text=If%20you%20return%20a%20promise,the%20finally%20block%20as%20expected.
Member
There was a problem hiding this comment.
Yes, because you already have the await startSpan which resolves the promise which got returned here.
JPeer264
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today server-side Sentry does not work for Tanstack Start if run in serverless environments. Deployment works fine, but no data is actually sent to Sentry. After some experimentation I figured out that we can make it work if we make the following two changes:
instrument.server.mjsin theserver.tsfile that has the server entry point. Eventually we can do this automatically during the build, but for now I'll update the documentation to do that.flushed(), so that data is sent off before the serverless function dies. This PR adds aflushIfServerless()call to thewrapFetchWithSentrywrapper.With these modifications errors, logs and basic tracing work (tested on Netlify and Vercel). For cloudflare we'll likely need a slightly modified approach.
Tests:
flush()is called.Closes #19507